[GitHub] [helix] xyuanlu commented on pull request #2439: Add a Trie class to represent RecursivePersistWatcherListener in ZkClient

["xyuanlu (via GitHub)" <gi...@apache.org>]

xyuanlu commented on PR #2439:
URL: https://github.com/apache/helix/pull/2439#issuecomment-1507759792

   > It would be better you have a search API to find the node for Trie class. It can be both find and delete leveraged.
   
   I am planning to add a search API to find the longest prefix -essentially find the node for Trie class. It will be added in following PR.
   
   > In addition, I dont see the need to delete node one by one. You can use whatever BFS, DFS to get each subnode unsubscribe. But just remove the top subtree node directly.
   
   Good point. Will update. 
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org