[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8569: stm32_eth: Fixed alignment of Ethernet descriptors & buffers.

["pkarashchenko (via GitHub)" <gi...@apache.org>]

pkarashchenko commented on code in PR #8569:
URL: https://github.com/apache/nuttx/pull/8569#discussion_r1110603492


##########
arch/arm/src/stm32/stm32_eth.c:
##########
@@ -634,22 +634,26 @@ struct stm32_ethmac_s
   uint16_t             segments;    /* RX segment count */
   uint16_t             inflight;    /* Number of TX transfers "in_flight" */
   sq_queue_t           freeb;       /* The free buffer list */
-
-  /* Descriptor allocations */
-
-  struct eth_rxdesc_s rxtable[CONFIG_STM32_ETH_NRXDESC];

Review Comment:
   Why pull out of the struct and not just add `align` intrude the struct? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org