You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/08/30 07:01:21 UTC
[GitHub] [hudi] YannByron commented on a diff in pull request #6476: [HUDI-3478] Support CDC for Spark in Hudi
YannByron commented on code in PR #6476:
URL: https://github.com/apache/hudi/pull/6476#discussion_r958080074
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java:
##########
@@ -465,23 +464,6 @@ public List<WriteStatus> writeStatuses() {
return statuses;
}
- private Writer createLogWriter(Option<FileSlice> fileSlice, String baseCommitTime)
Review Comment:
Just move it to the parent class `HoodieWriteHandle`, so that this function can be reused in `HoodieMergeHandle` too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org