You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "prashantwason (via GitHub)" <gi...@apache.org> on 2023/04/18 20:17:29 UTC

[GitHub] [hudi] prashantwason opened a new pull request, #8494: [HUDI-6099] Improved the performance of checking for valid commits when tagging record location.

prashantwason opened a new pull request, #8494:
URL: https://github.com/apache/hudi/pull/8494

   [HUDI-6099] Improved the performance of checking for valid commits when tagging record location.
   
   ### Change Logs
   
   1. Moved the checkIfValidCommit function to HoodieIndexUtils so that it can be shared across various indexes.
   2. checkIfValidCommit not accepts a HoodieTimeline instead of HoodieTableMetaClient. Hence, the timeline does not need to be computed for checking each and every record.
   3. Fixes HoodieInMemoryHashIndex which was not checking for valid commit when tagging location.
   
   ### Impact
   
   Improved performance when tagging a large number of records.
   
   ### Risk level (write none, low medium or high below)
   
   None. 
   
   Basically a code reorg.
   
   ### Documentation Update
   
   None
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] danny0405 merged pull request #8494: [HUDI-6099] Improved the performance of checking for valid commits when tagging record location.

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #8494:
URL: https://github.com/apache/hudi/pull/8494


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8494: [HUDI-6099] Improved the performance of checking for valid commits when tagging record location.

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8494:
URL: https://github.com/apache/hudi/pull/8494#issuecomment-1514364831

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8a8dc2bf299366d38863f18306deb5236514fea8",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16445",
       "triggerID" : "8a8dc2bf299366d38863f18306deb5236514fea8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8a8dc2bf299366d38863f18306deb5236514fea8 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16445) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8494: [HUDI-6099] Improved the performance of checking for valid commits when tagging record location.

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8494:
URL: https://github.com/apache/hudi/pull/8494#issuecomment-1513794651

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8a8dc2bf299366d38863f18306deb5236514fea8",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16445",
       "triggerID" : "8a8dc2bf299366d38863f18306deb5236514fea8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8a8dc2bf299366d38863f18306deb5236514fea8 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16445) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8494: [HUDI-6099] Improved the performance of checking for valid commits when tagging record location.

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8494:
URL: https://github.com/apache/hudi/pull/8494#issuecomment-1513786305

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8a8dc2bf299366d38863f18306deb5236514fea8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "8a8dc2bf299366d38863f18306deb5236514fea8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8a8dc2bf299366d38863f18306deb5236514fea8 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org