[jira] [Comment Edited] (WICKET-6214) ModalWindow broken on IE

["Sven Meier (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-6214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389442#comment-15389442 ] 

Sven Meier edited comment on WICKET-6214 at 7/22/16 12:55 PM:
--------------------------------------------------------------

Seems like jQuery has a guard against double "fixing":

{code}
	fix: function( originalEvent ) {
		return originalEvent[ jQuery.expando ] ?
			originalEvent :
			new jQuery.Event( originalEvent );
	},
{code}
https://github.com/jquery/jquery/blob/master/src/event.js#L437


was (Author: svenmeier):
Seems like jQuery has a guard agains double "fixing":

{code}
	fix: function( originalEvent ) {
		return originalEvent[ jQuery.expando ] ?
			originalEvent :
			new jQuery.Event( originalEvent );
	},
{code}
https://github.com/jquery/jquery/blob/master/src/event.js#L437

> ModalWindow broken on IE
> ------------------------
>
>                 Key: WICKET-6214
>                 URL: https://issues.apache.org/jira/browse/WICKET-6214
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 6.23.0, 6.24.0
>            Reporter: Sven Meier
>            Assignee: Martin Grigorov
>            Priority: Minor
>
> Since WICKET-6108 wicket-event-jquery.js no longer fixes passed in events:
> {code}
> 	fix: function (evt) {
> -		var evnt = evt || window.event;
> -		return jQuery.event.fix(evnt);
> +		return evt || jQuery.event.fix(window.event);
>  	},
> {code}
> But modal.js directly invokes {{Wicket.Event#stop()}}:
> {code}
>  	onmousedown=\"Wicket.Event.stop(event);\"
> {code}
> Thus the event is not 'fixed', but {{#stopPropagation()}} is called on it:
> {code}
> 	stop: function (evt, immediate) {
> 		evt = Wicket.Event.fix(evt);
> 		if (immediate) {
> 			evt.stopImmediatePropagation();
> 		} else {
> 			evt.stopPropagation();
> 		}
> 		return evt;
> 	},
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)