You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/12 19:30:48 UTC

[GitHub] [superset] kkucharc opened a new pull request #12468: fix: Added message flash when chart with missing dataset is accessed.

kkucharc opened a new pull request #12468:
URL: https://github.com/apache/superset/pull/12468


   ### SUMMARY
   Chart with deleted dataset is still available on charts list. While trying to access its explore view page redirects to charts list page. As discussed in issue #12464, I added flash notification message in right bottom corner.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   [Link to previous behaviour video] (https://user-images.githubusercontent.com/25153919/104351996-6655dd00-5506-11eb-929d-a7c1593098e0.mov)
   
   After:
   ![Large GIF (1366x756)](https://user-images.githubusercontent.com/2536609/104362538-357ca480-5514-11eb-9e76-961aaca0d0bf.gif)
   
   
   ### TEST PLAN
   1. Go to charts list and remember choose chart by dataset
   2. Go to list of datasets
   3. Delete chosen dataset
   4. Come back to charts list and try access charts previously chosen (it will have empty dataset name)
   5. It should redirect to charts list and show notification of missing chart and dataset:
   `The datasource associated with this chart no longer exists`
   
   
   ### ADDITIONAL INFORMATION
   - [x] Has associated issue: #12464
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] nytai commented on a change in pull request #12468: fix: Added message flash when chart with missing dataset is accessed.

Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #12468:
URL: https://github.com/apache/superset/pull/12468#discussion_r556049336



##########
File path: superset/views/core.py
##########
@@ -702,7 +702,8 @@ def explore(  # pylint: disable=too-many-locals,too-many-return-statements
             datasource_id, datasource_type = get_datasource_info(
                 datasource_id, datasource_type, form_data
             )
-        except SupersetException:
+        except SupersetException as e:
+            flash(e.message, "danger")

Review comment:
       This seems like a good pattern in general :) 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] kkucharc commented on pull request #12468: fix: Added message flash when chart with missing dataset is accessed.

Posted by GitBox <gi...@apache.org>.
kkucharc commented on pull request #12468:
URL: https://github.com/apache/superset/pull/12468#issuecomment-758908063


   > just one quick change - "datasource" to "dataset" in the message πŸ™
   
   It's done πŸ‘ 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] kkucharc commented on a change in pull request #12468: fix: Added message flash when chart with missing dataset is accessed.

Posted by GitBox <gi...@apache.org>.
kkucharc commented on a change in pull request #12468:
URL: https://github.com/apache/superset/pull/12468#discussion_r556546280



##########
File path: superset/views/core.py
##########
@@ -703,6 +703,7 @@ def explore(  # pylint: disable=too-many-locals,too-many-return-statements
                 datasource_id, datasource_type, form_data
             )
         except SupersetException:
+            flash("The dataset associated with this chart no longer exists", "danger")

Review comment:
       Thanks for suggestions! I updated message. I think it would be worth to add an issue to refactor `datasource` <-> `dataset` naming convention. WDYT? @nytai @ktmud 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] adam-stasiak commented on pull request #12468: fix: Added message flash when chart with missing dataset is accessed.

Posted by GitBox <gi...@apache.org>.
adam-stasiak commented on pull request #12468:
URL: https://github.com/apache/superset/pull/12468#issuecomment-759074822


   @zuzana-vej Now we have situation like on video - 
   https://user-images.githubusercontent.com/25153919/104351996-6655dd00-5506-11eb-929d-a7c1593098e0.mov
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] kkucharc commented on a change in pull request #12468: fix: Added message flash when chart with missing dataset is accessed.

Posted by GitBox <gi...@apache.org>.
kkucharc commented on a change in pull request #12468:
URL: https://github.com/apache/superset/pull/12468#discussion_r556052174



##########
File path: superset/views/core.py
##########
@@ -702,7 +702,8 @@ def explore(  # pylint: disable=too-many-locals,too-many-return-statements
             datasource_id, datasource_type = get_datasource_info(
                 datasource_id, datasource_type, form_data
             )
-        except SupersetException:
+        except SupersetException as e:
+            flash(e.message, "danger")

Review comment:
       Thanks @nytai ! :) Unfortunately I updated message after @junlincc [comment](https://github.com/apache/superset/pull/12468#issuecomment-758899747). Maybe we should change name of variables if those are now `datasets`? WDYT?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] ktmud commented on a change in pull request #12468: fix: Added message flash when chart with missing dataset is accessed.

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12468:
URL: https://github.com/apache/superset/pull/12468#discussion_r556072568



##########
File path: superset/views/core.py
##########
@@ -703,6 +703,7 @@ def explore(  # pylint: disable=too-many-locals,too-many-return-statements
                 datasource_id, datasource_type, form_data
             )
         except SupersetException:
+            flash("The dataset associated with this chart no longer exists", "danger")

Review comment:
       And don't forget to add i18n: 
   
   ```python
   _("Error occurred while trying to open the chart: %(error)", error=utils.error_msg_from_exception(ex))
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] junlincc commented on pull request #12468: fix: Added message flash when chart with missing dataset is accessed.

Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #12468:
URL: https://github.com/apache/superset/pull/12468#issuecomment-758899747


   just one quick change - "datasource" to "dataset" in the message πŸ™


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #12468: fix: Added message flash when chart with missing dataset is accessed.

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12468:
URL: https://github.com/apache/superset/pull/12468#issuecomment-759077814


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12468?src=pr&el=h1) Report
   > Merging [#12468](https://codecov.io/gh/apache/superset/pull/12468?src=pr&el=desc) (79c2dde) into [master](https://codecov.io/gh/apache/superset/commit/d8f4443c10114216eea630f826d86f6f85a1b0c2?el=desc) (d8f4443) will **decrease** coverage by `15.82%`.
   > The diff coverage is `84.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12468/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12468?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #12468       +/-   ##
   ===========================================
   - Coverage   66.81%   50.98%   -15.83%     
   ===========================================
     Files        1015      473      -542     
     Lines       49548    16872    -32676     
     Branches     5080     4341      -739     
   ===========================================
   - Hits        33106     8603    -24503     
   + Misses      16312     8269     -8043     
   + Partials      130        0      -130     
   ```
   
   | Flag | Coverage Ξ” | |
   |---|---|---|
   | cypress | `50.98% <84.00%> (+0.01%)` | :arrow_up: |
   | javascript | `?` | |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12468?src=pr&el=tree) | Coverage Ξ” | |
   |---|---|---|
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `69.54% <ΓΈ> (-7.62%)` | :arrow_down: |
   | [superset-frontend/src/components/AnchorLink.jsx](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQW5jaG9yTGluay5qc3g=) | `66.66% <ΓΈ> (-29.17%)` | :arrow_down: |
   | [superset-frontend/src/components/OmniContainer.jsx](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT21uaUNvbnRhaW5lci5qc3g=) | `60.00% <ΓΈ> (ΓΈ)` | |
   | [.../src/components/dataViewCommon/TableCollection.tsx](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvZGF0YVZpZXdDb21tb24vVGFibGVDb2xsZWN0aW9uLnRzeA==) | `100.00% <ΓΈ> (ΓΈ)` | |
   | [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `81.57% <ΓΈ> (+1.32%)` | :arrow_up: |
   | [...components/controls/DateFilterControl/constants.ts](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb25zdGFudHMudHM=) | `100.00% <ΓΈ> (ΓΈ)` | |
   | [...ore/components/controls/DateFilterControl/types.ts](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC90eXBlcy50cw==) | `100.00% <ΓΈ> (ΓΈ)` | |
   | [superset-frontend/src/explore/constants.js](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29uc3RhbnRzLmpz) | `100.00% <ΓΈ> (ΓΈ)` | |
   | [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `16.25% <ΓΈ> (-10.58%)` | :arrow_down: |
   | [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `68.96% <0.00%> (-3.19%)` | :arrow_down: |
   | ... and [874 more](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12468?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Ξ” = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12468?src=pr&el=footer). Last update [d8f4443...e5c98dc](https://codecov.io/gh/apache/superset/pull/12468?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #12468: fix: Added message flash when chart with missing dataset is accessed.

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12468:
URL: https://github.com/apache/superset/pull/12468#issuecomment-759077814






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] ktmud commented on a change in pull request #12468: fix: Added message flash when chart with missing dataset is accessed.

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12468:
URL: https://github.com/apache/superset/pull/12468#discussion_r556072568



##########
File path: superset/views/core.py
##########
@@ -703,6 +703,7 @@ def explore(  # pylint: disable=too-many-locals,too-many-return-statements
                 datasource_id, datasource_type, form_data
             )
         except SupersetException:
+            flash("The dataset associated with this chart no longer exists", "danger")

Review comment:
       And don't forget to add i18n: 
   
   ```python
   _("Error occurred when opening the chart: %(error)", error=utils.error_msg_from_exception(ex))
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] ktmud commented on a change in pull request #12468: fix: Added message flash when chart with missing dataset is accessed.

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12468:
URL: https://github.com/apache/superset/pull/12468#discussion_r557000307



##########
File path: superset/views/core.py
##########
@@ -703,6 +703,7 @@ def explore(  # pylint: disable=too-many-locals,too-many-return-statements
                 datasource_id, datasource_type, form_data
             )
         except SupersetException:
+            flash("The dataset associated with this chart no longer exists", "danger")

Review comment:
       @kkucharc I think it's definitely worth creating a separate PR to change the naming for user-facing text and messages, not so sure about the code though.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io commented on pull request #12468: fix: Added message flash when chart with missing dataset is accessed.

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12468:
URL: https://github.com/apache/superset/pull/12468#issuecomment-759077814


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12468?src=pr&el=h1) Report
   > Merging [#12468](https://codecov.io/gh/apache/superset/pull/12468?src=pr&el=desc) (6913ac6) into [master](https://codecov.io/gh/apache/superset/commit/d8f4443c10114216eea630f826d86f6f85a1b0c2?el=desc) (d8f4443) will **decrease** coverage by `15.82%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12468/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12468?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #12468       +/-   ##
   ===========================================
   - Coverage   66.81%   50.99%   -15.83%     
   ===========================================
     Files        1015      473      -542     
     Lines       49548    16872    -32676     
     Branches     5080     4341      -739     
   ===========================================
   - Hits        33106     8604    -24502     
   + Misses      16312     8268     -8044     
   + Partials      130        0      -130     
   ```
   
   | Flag | Coverage Ξ” | |
   |---|---|---|
   | cypress | `50.99% <ΓΈ> (+0.01%)` | :arrow_up: |
   | javascript | `?` | |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12468?src=pr&el=tree) | Coverage Ξ” | |
   |---|---|---|
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
   | [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
   | [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
   | [superset-frontend/src/components/IconTooltip.tsx](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvblRvb2x0aXAudHN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
   | [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
   | [...end/src/SqlLab/components/ExploreResultsButton.jsx](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uLmpzeA==) | `8.00% <0.00%> (-84.00%)` | :arrow_down: |
   | [...nd/src/views/CRUD/data/query/QueryPreviewModal.tsx](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9xdWVyeS9RdWVyeVByZXZpZXdNb2RhbC50c3g=) | `14.70% <0.00%> (-82.97%)` | :arrow_down: |
   | ... and [866 more](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12468?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Ξ” = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12468?src=pr&el=footer). Last update [d8f4443...27737d1](https://codecov.io/gh/apache/superset/pull/12468?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] kkucharc closed pull request #12468: fix: Added message flash when chart with missing dataset is accessed.

Posted by GitBox <gi...@apache.org>.
kkucharc closed pull request #12468:
URL: https://github.com/apache/superset/pull/12468


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] junlincc merged pull request #12468: fix: Added message flash when chart with missing dataset is accessed.

Posted by GitBox <gi...@apache.org>.
junlincc merged pull request #12468:
URL: https://github.com/apache/superset/pull/12468


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] adam-stasiak edited a comment on pull request #12468: fix: Added message flash when chart with missing dataset is accessed.

Posted by GitBox <gi...@apache.org>.
adam-stasiak edited a comment on pull request #12468:
URL: https://github.com/apache/superset/pull/12468#issuecomment-759074822


   @zuzana-vej Now we have situation like on video - 
   https://user-images.githubusercontent.com/25153919/104351996-6655dd00-5506-11eb-929d-a7c1593098e0.mov
   So user stay son listing and does not have information why cannot access


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #12468: fix: Added message flash when chart with missing dataset is accessed.

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12468:
URL: https://github.com/apache/superset/pull/12468#issuecomment-759077814


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12468?src=pr&el=h1) Report
   > Merging [#12468](https://codecov.io/gh/apache/superset/pull/12468?src=pr&el=desc) (27737d1) into [master](https://codecov.io/gh/apache/superset/commit/d8f4443c10114216eea630f826d86f6f85a1b0c2?el=desc) (d8f4443) will **decrease** coverage by `3.06%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12468/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12468?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12468      +/-   ##
   ==========================================
   - Coverage   66.81%   63.75%   -3.07%     
   ==========================================
     Files        1015      486     -529     
     Lines       49548    29915   -19633     
     Branches     5080        0    -5080     
   ==========================================
   - Hits        33106    19072   -14034     
   + Misses      16312    10843    -5469     
   + Partials      130        0     -130     
   ```
   
   | Flag | Coverage Ξ” | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.75% <0.00%> (-0.33%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12468?src=pr&el=tree) | Coverage Ξ” | |
   |---|---|---|
   | [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.84% <0.00%> (-2.54%)` | :arrow_down: |
   | [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
   | [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
   | [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <0.00%> (-4.35%)` | :arrow_down: |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.86% <0.00%> (-2.99%)` | :arrow_down: |
   | ... and [538 more](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12468?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Ξ” = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12468?src=pr&el=footer). Last update [d8f4443...27737d1](https://codecov.io/gh/apache/superset/pull/12468?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] zuzana-vej commented on pull request #12468: fix: Added message flash when chart with missing dataset is accessed.

Posted by GitBox <gi...@apache.org>.
zuzana-vej commented on pull request #12468:
URL: https://github.com/apache/superset/pull/12468#issuecomment-759048720


   What is the current behavior? User gets redirected to Explore and then sees an error message because the underlying datasource doesn't exist right? 
   While not having user go to the chart Explore to find this information out is generally great, there might be some legit cases when user (especially owner) still want to access such chart - for example when they are trying to see the configuration they set up to build a new chart, or if they want to specify new dataset.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] nytai commented on a change in pull request #12468: fix: Added message flash when chart with missing dataset is accessed.

Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #12468:
URL: https://github.com/apache/superset/pull/12468#discussion_r556057545



##########
File path: superset/views/core.py
##########
@@ -703,6 +703,7 @@ def explore(  # pylint: disable=too-many-locals,too-many-return-statements
                 datasource_id, datasource_type, form_data
             )
         except SupersetException:
+            flash("The dataset associated with this chart no longer exists", "danger")

Review comment:
       I think there could be other reasons for an exception, we should use the actual error message




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] ktmud commented on a change in pull request #12468: fix: Added message flash when chart with missing dataset is accessed.

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12468:
URL: https://github.com/apache/superset/pull/12468#discussion_r556072568



##########
File path: superset/views/core.py
##########
@@ -703,6 +703,7 @@ def explore(  # pylint: disable=too-many-locals,too-many-return-statements
                 datasource_id, datasource_type, form_data
             )
         except SupersetException:
+            flash("The dataset associated with this chart no longer exists", "danger")

Review comment:
       And don't forget to add i18n: 
   
   ```python
   _("Error occurred when trying to open the chart: %(error), error=utils.error_msg_from_exception(ex))
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] kkucharc commented on pull request #12468: fix: Added message flash when chart with missing dataset is accessed.

Posted by GitBox <gi...@apache.org>.
kkucharc commented on pull request #12468:
URL: https://github.com/apache/superset/pull/12468#issuecomment-762271385


   Same here:
   
   Before:
   <img width="1102" alt="Screenshot 2021-01-18 at 14 36 37" src="https://user-images.githubusercontent.com/2536609/104924880-59ba0480-599e-11eb-919f-d72eea2b9a53.png">
   
   After:
   <img width="1123" alt="Screenshot 2021-01-18 at 14 41 06" src="https://user-images.githubusercontent.com/2536609/104924903-6179a900-599e-11eb-816d-f5de6db6331e.png">
   
   Maybe it's something in sorting or Dataset filter?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] nytai commented on pull request #12468: fix: Added message flash when chart with missing dataset is accessed.

Posted by GitBox <gi...@apache.org>.
nytai commented on pull request #12468:
URL: https://github.com/apache/superset/pull/12468#issuecomment-758914039


   @kkucharc I think changing the underlying exception message makes more sense. We're trying to go with "dataset" moving forward. Also please wrap messages in babel translation `_()` function for i18n 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #12468: fix: Added message flash when chart with missing dataset is accessed.

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12468:
URL: https://github.com/apache/superset/pull/12468#issuecomment-759077814


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12468?src=pr&el=h1) Report
   > Merging [#12468](https://codecov.io/gh/apache/superset/pull/12468?src=pr&el=desc) (cb292a4) into [master](https://codecov.io/gh/apache/superset/commit/d8f4443c10114216eea630f826d86f6f85a1b0c2?el=desc) (d8f4443) will **decrease** coverage by `3.71%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12468/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12468?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12468      +/-   ##
   ==========================================
   - Coverage   66.81%   63.10%   -3.72%     
   ==========================================
     Files        1015      485     -530     
     Lines       49548    29945   -19603     
     Branches     5080        0    -5080     
   ==========================================
   - Hits        33106    18897   -14209     
   + Misses      16312    11048    -5264     
   + Partials      130        0     -130     
   ```
   
   | Flag | Coverage Ξ” | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.10% <0.00%> (-0.98%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12468?src=pr&el=tree) | Coverage Ξ” | |
   |---|---|---|
   | [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.84% <0.00%> (-2.54%)` | :arrow_down: |
   | [superset/views/utils.py](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.23% <ΓΈ> (ΓΈ)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `30.98% <0.00%> (-69.02%)` | :arrow_down: |
   | [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/examples/helpers.py](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvaGVscGVycy5weQ==) | `85.36% <0.00%> (-12.20%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
   | ... and [557 more](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12468?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Ξ” = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12468?src=pr&el=footer). Last update [d8f4443...cb292a4](https://codecov.io/gh/apache/superset/pull/12468?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] adam-stasiak commented on pull request #12468: fix: Added message flash when chart with missing dataset is accessed.

Posted by GitBox <gi...@apache.org>.
adam-stasiak commented on pull request #12468:
URL: https://github.com/apache/superset/pull/12468#issuecomment-762267868


   @junlincc Could you describe steps to reproduce - > I tried to delete datasets and charts remain.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #12468: fix: Added message flash when chart with missing dataset is accessed.

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12468:
URL: https://github.com/apache/superset/pull/12468#issuecomment-759077814


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12468?src=pr&el=h1) Report
   > Merging [#12468](https://codecov.io/gh/apache/superset/pull/12468?src=pr&el=desc) (cb292a4) into [master](https://codecov.io/gh/apache/superset/commit/d8f4443c10114216eea630f826d86f6f85a1b0c2?el=desc) (d8f4443) will **decrease** coverage by `3.71%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12468/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12468?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12468      +/-   ##
   ==========================================
   - Coverage   66.81%   63.10%   -3.72%     
   ==========================================
     Files        1015      485     -530     
     Lines       49548    29945   -19603     
     Branches     5080        0    -5080     
   ==========================================
   - Hits        33106    18897   -14209     
   + Misses      16312    11048    -5264     
   + Partials      130        0     -130     
   ```
   
   | Flag | Coverage Ξ” | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.10% <0.00%> (-0.98%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12468?src=pr&el=tree) | Coverage Ξ” | |
   |---|---|---|
   | [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.84% <0.00%> (-2.54%)` | :arrow_down: |
   | [superset/views/utils.py](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.23% <ΓΈ> (ΓΈ)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `30.98% <0.00%> (-69.02%)` | :arrow_down: |
   | [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/examples/helpers.py](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvaGVscGVycy5weQ==) | `85.36% <0.00%> (-12.20%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
   | ... and [557 more](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12468?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Ξ” = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12468?src=pr&el=footer). Last update [d8f4443...cb292a4](https://codecov.io/gh/apache/superset/pull/12468?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #12468: fix: Added message flash when chart with missing dataset is accessed.

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12468:
URL: https://github.com/apache/superset/pull/12468#issuecomment-759077814


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12468?src=pr&el=h1) Report
   > Merging [#12468](https://codecov.io/gh/apache/superset/pull/12468?src=pr&el=desc) (cb292a4) into [master](https://codecov.io/gh/apache/superset/commit/d8f4443c10114216eea630f826d86f6f85a1b0c2?el=desc) (d8f4443) will **decrease** coverage by `3.71%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12468/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12468?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12468      +/-   ##
   ==========================================
   - Coverage   66.81%   63.10%   -3.72%     
   ==========================================
     Files        1015      485     -530     
     Lines       49548    29945   -19603     
     Branches     5080        0    -5080     
   ==========================================
   - Hits        33106    18897   -14209     
   + Misses      16312    11048    -5264     
   + Partials      130        0     -130     
   ```
   
   | Flag | Coverage Ξ” | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.10% <0.00%> (-0.98%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12468?src=pr&el=tree) | Coverage Ξ” | |
   |---|---|---|
   | [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.84% <0.00%> (-2.54%)` | :arrow_down: |
   | [superset/views/utils.py](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.23% <ΓΈ> (ΓΈ)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `30.98% <0.00%> (-69.02%)` | :arrow_down: |
   | [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/examples/helpers.py](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvaGVscGVycy5weQ==) | `85.36% <0.00%> (-12.20%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
   | ... and [557 more](https://codecov.io/gh/apache/superset/pull/12468/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12468?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Ξ” = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12468?src=pr&el=footer). Last update [d8f4443...cb292a4](https://codecov.io/gh/apache/superset/pull/12468?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org