You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Qifan Chen (Code Review)" <ge...@cloudera.org> on 2021/04/09 17:01:22 UTC

[Impala-ASF-CR] [WIP] IMPALA-10650: Bailout min/max filters in hash join builder early

Qifan Chen has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/17295 )

Change subject: [WIP] IMPALA-10650: Bailout min/max filters in hash join builder early
......................................................................

[WIP] IMPALA-10650: Bailout min/max filters in hash join builder early

This change set addresses the weakness in population min/max filters
in the hash join builder by periodically measuring the usefulness of
each such filter and set the AlwaysTrue flag to true. For each insert
into a not useful filter, this reduces the amount of work from at
least two comparisons and two conditional assignments to one Boolean
test.

Change-Id: I193646e7acfdd3023f7c947d8107da58a1f41183
---
M be/src/exec/filter-context.cc
M be/src/exec/filter-context.h
M be/src/exec/partitioned-hash-join-builder.cc
M be/src/exec/partitioned-hash-join-builder.h
M be/src/util/min-max-filter-ir.cc
M be/src/util/min-max-filter.cc
6 files changed, 60 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/95/17295/5
-- 
To view, visit http://gerrit.cloudera.org:8080/17295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I193646e7acfdd3023f7c947d8107da58a1f41183
Gerrit-Change-Number: 17295
Gerrit-PatchSet: 5
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>