[GitHub] srowen commented on a change in pull request #23457: [SPARK-26539][CORE] Remove spark.memory.useLegacyMode and StaticMemoryManager

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #23457: [SPARK-26539][CORE] Remove spark.memory.useLegacyMode and StaticMemoryManager
URL: https://github.com/apache/spark/pull/23457#discussion_r245426337
 
 

 ##########
 File path: core/src/test/scala/org/apache/spark/util/collection/ExternalAppendOnlyMapSuite.scala
 ##########
 @@ -550,12 +550,11 @@ class ExternalAppendOnlyMapSuite extends SparkFunSuite
 
   test("force to spill for external aggregation") {
     val conf = createSparkConf(loadDefaults = false)
-      .set("spark.shuffle.memoryFraction", "0.01")
-      .set("spark.memory.useLegacyMode", "true")
-      .set("spark.testing.memory", "100000000")
+      .set("spark.memory.storageFraction", "0.999")
+      .set("spark.testing.memory", "471859200")
 
 Review comment:
   This is the minimum allowed value. The new setting 0.999 mimics having almost no shuffle memory

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org