You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "Divij Vaidya (Jira)" <ji...@apache.org> on 2020/09/27 02:43:00 UTC
[jira] [Commented] (TINKERPOP-2427) Simplify Netty reference
counting
[ https://issues.apache.org/jira/browse/TINKERPOP-2427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202720#comment-17202720 ]
Divij Vaidya commented on TINKERPOP-2427:
-----------------------------------------
PR: https://github.com/apache/tinkerpop/pull/1334
> Simplify Netty reference counting
> ---------------------------------
>
> Key: TINKERPOP-2427
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2427
> Project: TinkerPop
> Issue Type: Improvement
> Components: driver
> Affects Versions: 3.5.0, 3.4.8
> Reporter: Divij Vaidya
> Priority: Minor
>
> We have some incorrect configuration in the code such as:
> [https://github.com/apache/tinkerpop/blob/3.4-dev/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/handler/WebSocketGremlinResponseDecoder.java#L59] (MessageToMessageDecoder automatically decreases the reference count).
> [https://github.com/apache/tinkerpop/blob/3.4-dev/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Handler.java#L270] (SimpleChannelInboundHandler automatically decreases the reference count).
> which are fixed by hardcoding values such as:
> [https://github.com/apache/tinkerpop/blob/3.4-dev/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/handler/WebSocketClientHandler.java#L89]
> This Jira will fix the reference counting correctly and eliminate the need for hardcoding.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)