You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by cakofony <gi...@git.apache.org> on 2018/02/27 05:42:20 UTC

[GitHub] logging-log4j2 pull request #156: Update ParameterConsumer index type from s...

GitHub user cakofony opened a pull request:

    https://github.com/apache/logging-log4j2/pull/156

    Update ParameterConsumer index type from short to int

    Originally ParameterVisitable was built for ReusableMessage which
    provides a "short getParameterCount()" method. Now that the
    interface isn't bound to ReusableMessage it might as well use
    integer.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cakofony/logging-log4j2 parameter_consumer_index_type

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/logging-log4j2/pull/156.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #156
    
----
commit c8dc8ffc57aaa0a29ad70c51731379323b43dd51
Author: Carter Kozak <c4...@...>
Date:   2018-02-27T05:39:12Z

    Update ParameterConsumer index type from short to int
    
    Originally ParameterVisitable was built for ReusableMessage which
    provides a "short getParameterCount()" method. Now that the
    interface isn't bound to ReusableMessage it might as well use
    integer.

----


---

[GitHub] logging-log4j2 issue #156: Update ParameterConsumer index type from short to...

Posted by cakofony <gi...@git.apache.org>.

Github user cakofony commented on the issue:

    https://github.com/apache/logging-log4j2/pull/156
  
    Backport to `release-2.x` branch is here: #157


---

[GitHub] logging-log4j2 pull request #156: Update ParameterConsumer index type from s...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/logging-log4j2/pull/156


---

[GitHub] logging-log4j2 issue #156: Update ParameterConsumer index type from short to...

Posted by cakofony <gi...@git.apache.org>.

Github user cakofony commented on the issue:

    https://github.com/apache/logging-log4j2/pull/156
  
    based on feedback from @remkop 


---