You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/01/18 12:25:24 UTC

[GitHub] [fineract] vorburger commented on a change in pull request #1583: Fix MYSQL Restart Issue

vorburger commented on a change in pull request #1583:
URL: https://github.com/apache/fineract/pull/1583#discussion_r559530662



##########
File path: kubernetes/kubectl-startup.sh
##########
@@ -19,7 +19,7 @@
 #
 
 echo "Setting Up Fineract service configuration..."
-kubectl create secret generic fineract-tenants-db-secret --from-literal=username=root --from-literal=password=$(head /dev/urandom | tr -dc A-Za-z0-9 | head -c 16)
+kubectl create secret generic fineract-tenants-db-secret --from-literal=username=root --from-literal=password=root

Review comment:
       Wait a second... doesn't this hardcode it to"root"?! That's..  probably not such a good idea? 😎




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org