You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by jo...@apache.org on 2020/04/28 02:21:49 UTC

[impala] 02/02: Don't filter maven messages about banned dependencies

This is an automated email from the ASF dual-hosted git repository.

joemcdonnell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit afe765e3bdf8facb1940f4c7620eb7f9084bcb1f
Author: Joe McDonnell <jo...@cloudera.com>
AuthorDate: Mon Apr 27 12:01:41 2020 -0700

    Don't filter maven messages about banned dependencies
    
    The frontend build uses the maven-enforcer-plugin to ban
    some dependencies or require specific versions of dependencies.
    The messages look like:
    Found Banned Dependency: foo.bar.baz:1.2.3
    
    These are currently filtered by bin/mvn-quiet.sh. This adds
    an exception for "Found Banned" so they are not filtered.
    
    Testing:
     - Ran on a branch with a known banned dependency and verified
       the output
    
    Change-Id: I24abe59ad6bffb28ac63d014aa0ec7388ef5478f
    Reviewed-on: http://gerrit.cloudera.org:8080/15820
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
    Reviewed-by: David Knupp <dk...@cloudera.com>
---
 bin/mvn-quiet.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/bin/mvn-quiet.sh b/bin/mvn-quiet.sh
index cc673da..f782ff4 100755
--- a/bin/mvn-quiet.sh
+++ b/bin/mvn-quiet.sh
@@ -36,7 +36,8 @@ LOGGING_OPTIONS="-Dorg.slf4j.simpleLogger.showDateTime \
 
 # Always use maven's batch mode (-B), as it produces output that is easier to parse.
 if ! mvn -B $IMPALA_MAVEN_OPTIONS $LOGGING_OPTIONS "$@" | \
-  tee -a "$LOG_FILE" | grep -E -e WARNING -e ERROR -e SUCCESS -e FAILURE -e Test; then
+  tee -a "$LOG_FILE" | \
+  grep -E -e WARNING -e ERROR -e SUCCESS -e FAILURE -e Test -e "Found Banned"; then
   echo "mvn $IMPALA_MAVEN_OPTIONS $@ exited with code $?"
   exit 1
 fi