You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/01/10 03:08:53 UTC
[GitHub] [servicecomb-service-center] little-cui opened a new pull request
#618: SCB-1712 Reset kv cache periodically
little-cui opened a new pull request #618: SCB-1712 Reset kv cache periodically
URL: https://github.com/apache/servicecomb-service-center/pull/618
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-service-center] codecov-io commented on issue #618:
SCB-1712 Reset kv cache periodically
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #618: SCB-1712 Reset kv cache periodically
URL: https://github.com/apache/servicecomb-service-center/pull/618#issuecomment-572856134
# [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/618?src=pr&el=h1) Report
> Merging [#618](https://codecov.io/gh/apache/servicecomb-service-center/pull/618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/fc3f5a0e7109ffb163fd01b1e4020559b07c9b2e?src=pr&el=desc) will **decrease** coverage by `0.04%`.
> The diff coverage is `42.5%`.
[](https://codecov.io/gh/apache/servicecomb-service-center/pull/618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #618 +/- ##
==========================================
- Coverage 57.56% 57.52% -0.05%
==========================================
Files 205 205
Lines 15776 15809 +33
==========================================
+ Hits 9082 9094 +12
- Misses 6043 6065 +22
+ Partials 651 650 -1
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/618?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/gopool/goroutines.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/618/diff?src=pr&el=tree#diff-cGtnL2dvcG9vbC9nb3JvdXRpbmVzLmdv) | `100% <ø> (ø)` | :arrow_up: |
| [server/service/util/microservice\_util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/618/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9taWNyb3NlcnZpY2VfdXRpbC5nbw==) | `63.18% <0%> (+0.68%)` | :arrow_up: |
| [server/core/backend/defer\_instance.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/618/diff?src=pr&el=tree#diff-c2VydmVyL2NvcmUvYmFja2VuZC9kZWZlcl9pbnN0YW5jZS5nbw==) | `80.8% <0%> (-5.22%)` | :arrow_down: |
| [server/plugin/pkg/discovery/cache\_null.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/618/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2NhY2hlX251bGwuZ28=) | `90% <0%> (-10%)` | :arrow_down: |
| [server/plugin/pkg/discovery/etcd/cacher\_kv.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/618/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2V0Y2QvY2FjaGVyX2t2Lmdv) | `64.8% <20%> (-1.62%)` | :arrow_down: |
| [server/plugin/pkg/discovery/cache\_kv.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/618/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2NhY2hlX2t2Lmdv) | `90.9% <37.5%> (-4.89%)` | :arrow_down: |
| [server/core/proto/parser.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/618/diff?src=pr&el=tree#diff-c2VydmVyL2NvcmUvcHJvdG8vcGFyc2VyLmdv) | `92.85% <85.71%> (-3.58%)` | :arrow_down: |
| [syncer/pkg/ticker/ticker.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/618/diff?src=pr&el=tree#diff-c3luY2VyL3BrZy90aWNrZXIvdGlja2VyLmdv) | `80.95% <0%> (-19.05%)` | :arrow_down: |
| [syncer/pkg/syssig/signal.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/618/diff?src=pr&el=tree#diff-c3luY2VyL3BrZy9zeXNzaWcvc2lnbmFsLmdv) | `64.51% <0%> (-3.23%)` | :arrow_down: |
| [server/broker/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/618/diff?src=pr&el=tree#diff-c2VydmVyL2Jyb2tlci91dGlsLmdv) | `53.47% <0%> (+0.26%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/618?src=pr&el=footer). Last update [fc3f5a0...5b0c3ef](https://codecov.io/gh/apache/servicecomb-service-center/pull/618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-service-center] tianxiaoliang merged pull request
#618: SCB-1712 Reset kv cache periodically
Posted by GitBox <gi...@apache.org>.
tianxiaoliang merged pull request #618: SCB-1712 Reset kv cache periodically
URL: https://github.com/apache/servicecomb-service-center/pull/618
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-service-center] coveralls commented on issue #618:
SCB-1712 Reset kv cache periodically
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #618: SCB-1712 Reset kv cache periodically
URL: https://github.com/apache/servicecomb-service-center/pull/618#issuecomment-572856114
[](https://coveralls.io/builds/28019488)
Coverage increased (+0.1%) to 60.076% when pulling **5b0c3ef09ae0b98f824973fda64c2fe8d8a27e53 on little-cui:master** into **fc3f5a0e7109ffb163fd01b1e4020559b07c9b2e on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services