You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@impala.apache.org by "Michael Ho (Code Review)" <ge...@cloudera.org> on 2016/06/24 21:39:06 UTC

[Impala-CR](cdh5-trunk) IMPALA-3206: Enable codegen for AVRO DECIMAL

Michael Ho has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3489

Change subject: IMPALA-3206: Enable codegen for AVRO_DECIMAL
......................................................................

IMPALA-3206: Enable codegen for AVRO_DECIMAL

This change adds the missing switch statement in
CodegenReadScalar() for AVRO_DECIMAL so that we will
also codegen if an avro table contains AVRO_DECIMAL.
With this change, the following query improves by 37.5%,
going from 8s to 5s:

select count(distinct l_linenumber), avg(l_extendedprice), max(l_discount), min(l_tax) from tpch15_avro.lineitem;

This change also un-inlines BitUtil::ByteSwap() as the
third argument 'len' is not compilation constant for
all call sites.

Change-Id: I51adf0c1ba76e055f31ccb0034a0d23ea2afb30e
---
M be/src/codegen/gen_ir_descriptions.py
M be/src/exec/hdfs-avro-scanner.cc
M be/src/util/CMakeLists.txt
R be/src/util/bit-util.cc
M be/src/util/bit-util.h
M be/src/util/decimal-util.h
6 files changed, 8 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/89/3489/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I51adf0c1ba76e055f31ccb0034a0d23ea2afb30e
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Ho <kw...@cloudera.com>

[Impala-CR](cdh5-trunk) IMPALA-3206: Enable codegen for AVRO DECIMAL

Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.

Internal Jenkins has submitted this change and it was merged.

Change subject: IMPALA-3206: Enable codegen for AVRO_DECIMAL
......................................................................


IMPALA-3206: Enable codegen for AVRO_DECIMAL

This change adds the missing switch statement in
CodegenReadScalar() for AVRO_DECIMAL so that we will
also codegen if an avro table contains AVRO_DECIMAL.
With this change, the following query improves by 37.5%,
going from 8s to 5s:

select count(distinct l_linenumber), avg(l_extendedprice), max(l_discount), min(l_tax) from tpch15_avro.lineitem;

This change also un-inlines BitUtil::ByteSwap() as the
third argument 'len' is not compilation constant for
all call sites.

Change-Id: I51adf0c1ba76e055f31ccb0034a0d23ea2afb30e
Reviewed-on: http://gerrit.cloudera.org:8080/3489
Reviewed-by: Michael Ho <kw...@cloudera.com>
Tested-by: Internal Jenkins
---
M be/src/codegen/gen_ir_descriptions.py
M be/src/exec/hdfs-avro-scanner.cc
M be/src/util/CMakeLists.txt
M be/src/util/bit-util-test.cc
R be/src/util/bit-util.cc
M be/src/util/bit-util.h
M be/src/util/decimal-util.h
M testdata/workloads/functional-query/queries/QueryTest/decimal_avro.test
8 files changed, 24 insertions(+), 11 deletions(-)

Approvals:
  Michael Ho: Looks good to me, approved
  Internal Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/3489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I51adf0c1ba76e055f31ccb0034a0d23ea2afb30e
Gerrit-PatchSet: 6
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-CR](cdh5-trunk) IMPALA-3206: Enable codegen for AVRO DECIMAL

Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.

Dan Hecht has posted comments on this change.

Change subject: IMPALA-3206: Enable codegen for AVRO_DECIMAL
......................................................................


Patch Set 4: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/3489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I51adf0c1ba76e055f31ccb0034a0d23ea2afb30e
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No