You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/02/06 23:36:57 UTC
Review Request 65538: WIP: Added provider assignments into
`disk_profile.proto`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65538/
-----------------------------------------------------------
Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.
Bugs: MESOS-8510
https://issues.apache.org/jira/browse/MESOS-8510
Repository: mesos
Description
-------
A new `assignments` field is added to the `DiskProfileMapping` protobuf
so that the URI disk profile adaptor can be customized to notify each
resource provider a different set of profiles.
Diffs
-----
src/resource_provider/storage/disk_profile.proto 6cf1f8abcd24e45a292efc95a395f90bb2140da2
Diff: https://reviews.apache.org/r/65538/diff/1/
Testing
-------
Thanks,
Chun-Hung Hsiao
Re: Review Request 65538: WIP: Added provider assignments into
`disk_profile.proto`.
Posted by James DeFelice <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65538/#review196965
-----------------------------------------------------------
src/resource_provider/storage/disk_profile.proto
Lines 39 (patched)
<https://reviews.apache.org/r/65538/#comment276960>
maybe add a comment that specifying a `selector` is REQUIRED?
- James DeFelice
On Feb. 7, 2018, 1:12 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65538/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2018, 1:12 a.m.)
>
>
> Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-8510
> https://issues.apache.org/jira/browse/MESOS-8510
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A new `assignments` field is added to the `DiskProfileMapping` protobuf
> so that the URI disk profile adaptor can be customized to notify each
> resource provider a different set of profiles.
>
>
> Diffs
> -----
>
> src/resource_provider/storage/disk_profile.proto 6cf1f8abcd24e45a292efc95a395f90bb2140da2
>
>
> Diff: https://reviews.apache.org/r/65538/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 65538: WIP: Added provider assignments into
`disk_profile.proto`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65538/#review196966
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['65032', '65471', '65472', '65060', '65499', '65520', '65534', '65523', '65521', '65061', '65522', '65538']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65538
Relevant logs:
- [mesos-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65538/logs/mesos-tests-cmake-stdout.log):
```
D:\DCOS\mesos\mesos\src\java\jni\convert.cpp(415): warning C4267: 'argument': conversion from 'size_t' to 'jsize', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
D:\DCOS\mesos\mesos\src\java\jni\convert.cpp(437): warning C4267: 'argument': conversion from 'size_t' to 'jsize', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
D:\DCOS\mesos\mesos\src\java\jni\convert.cpp(438): warning C4267: 'argument': conversion from 'size_t' to 'jsize', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
D:\DCOS\mesos\mesos\src\java\jni\convert.cpp(460): warning C4267: 'argument': conversion from 'size_t' to 'jsize', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
D:\DCOS\mesos\mesos\src\java\jni\convert.cpp(461): warning C4267: 'argument': conversion from 'size_t' to 'jsize', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
D:\DCOS\mesos\mesos\src\java\jni\convert.cpp(500): warning C4267: 'argument': conversion from 'size_t' to 'jsize', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
D:\DCOS\mesos\mesos\src\java\jni\convert.cpp(501): warning C4267: 'argument': conversion from 'size_t' to 'jsize', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
D:\DCOS\mesos\mesos\src\java\jni\org_apache_mesos_state_Variable.cpp(44): warning C4267: 'argument': conversion from 'size_t' to 'jsize', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
D:\DCOS\mesos\mesos\src\java\jni\org_apache_mesos_state_Variable.cpp(45): warning C4267: 'argument': conversion from 'size_t' to 'jsize', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
D:\DCOS\mesos\mesos\src\jvm\jvm.cpp(95): warning C4267: '=': conversion from 'size_t' to 'jint', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
D:\DCOS\mesos\mesos\src\jvm\jvm.cpp(463): warning C4244: 'initializing': conversion from 'jchar' to 'char', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
D:\DCOS\mesos\mesos\src\jvm\jvm.cpp(493): warning C4244: 'initializing': conversion from 'jlong' to 'long', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
D:\DCOS\mesos\mesos\src\jvm\jvm.cpp(654): warning C4244: 'initializing': conversion from 'jchar' to 'char', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
D:\DCOS\mesos\mesos\src\jvm\jvm.cpp(693): warning C4244: 'initializing': conversion from 'jlong' to 'long', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
D:\DCOS\mesos\mesos\src\jvm\jvm.cpp(770): warning C4244: 'initializing': conversion from 'jchar' to 'char', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
D:\DCOS\mesos\mesos\src\jvm\jvm.cpp(809): warning C4244: 'initializing': conversion from 'jlong' to 'long', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
"D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
(Link target) ->
cluster.obj : error LNK2019: unresolved external symbol "class Try<class std::list<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,class std::allocator<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > > >,class Error> __cdecl mesos::csi::paths::getContainerPaths(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &)" (?getContainerPaths@paths@csi@mesos@@YA?AV?$Try@V?$list@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@V?$allocator@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@2@@std@@VError@@@@AEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@00@Z) referenced in function "public: void __cdecl <lambda_ec4b6b812fb54f84d2a3b
9cb43048194>::operator()(void)const " (??R<lambda_ec4b6b812fb54f84d2a3b9cb43048194>@@QEBAXXZ) [D:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
cluster.obj : error LNK2019: unresolved external symbol "class Try<struct mesos::csi::paths::ContainerPath,class Error> __cdecl mesos::csi::paths::parseContainerPath(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &)" (?parseContainerPath@paths@csi@mesos@@YA?AV?$Try@UContainerPath@paths@csi@mesos@@VError@@@@AEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@0@Z) referenced in function "public: void __cdecl <lambda_ec4b6b812fb54f84d2a3b9cb43048194>::operator()(void)const " (??R<lambda_ec4b6b812fb54f84d2a3b9cb43048194>@@QEBAXXZ) [D:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
cluster.obj : error LNK2019: unresolved external symbol "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl mesos::csi::paths::getEndpointDirSymlinkPath(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class mesos::ContainerID const &)" (?getEndpointDirSymlinkPath@paths@csi@mesos@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV45@00AEBVContainerID@3@@Z) referenced in function "public: void __cdecl <lambda_ec4b6b812fb54f84d2a3b9cb43048194>::operator()(void)const " (??R<lambda_ec4b6b812fb54f84d2a3b9cb43048194>@@QEBAXXZ) [D:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
D:\DCOS\mesos\src\mesos-tests.exe : fatal error LNK1120: 3 unresolved externals [D:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
214 Warning(s)
4 Error(s)
Time Elapsed 00:27:20.69
```
- Mesos Reviewbot Windows
On Feb. 7, 2018, 1:12 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65538/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2018, 1:12 a.m.)
>
>
> Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-8510
> https://issues.apache.org/jira/browse/MESOS-8510
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A new `assignments` field is added to the `DiskProfileMapping` protobuf
> so that the URI disk profile adaptor can be customized to notify each
> resource provider a different set of profiles.
>
>
> Diffs
> -----
>
> src/resource_provider/storage/disk_profile.proto 6cf1f8abcd24e45a292efc95a395f90bb2140da2
>
>
> Diff: https://reviews.apache.org/r/65538/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 65538: Added provider assignments into
`disk_profile.proto`.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65538/#review197009
-----------------------------------------------------------
Fix it, then Ship it!
Can you update the summary and description of this review accordingly?
src/resource_provider/storage/disk_profile.proto
Line 32 (original), 51 (patched)
<https://reviews.apache.org/r/65538/#comment277120>
I don't change the tag number.
- Jie Yu
On Feb. 7, 2018, 6:51 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65538/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2018, 6:51 p.m.)
>
>
> Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-8510
> https://issues.apache.org/jira/browse/MESOS-8510
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A new `assignments` field is added to the `DiskProfileMapping` protobuf
> so that the URI disk profile adaptor can be customized to notify each
> resource provider a different set of profiles.
>
>
> Diffs
> -----
>
> src/resource_provider/storage/disk_profile.proto 6cf1f8abcd24e45a292efc95a395f90bb2140da2
>
>
> Diff: https://reviews.apache.org/r/65538/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 65538: WIP: Added profile selectors in
`disk_profile.proto`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65538/#review197048
-----------------------------------------------------------
PASS: Mesos patch 65538 was successfully built and tested.
Reviews applied: `['65553', '65554', '65538']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65538
- Mesos Reviewbot Windows
On Feb. 7, 2018, 1:07 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65538/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2018, 1:07 p.m.)
>
>
> Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-8510
> https://issues.apache.org/jira/browse/MESOS-8510
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds two selectors to the `CSIManifest` protobuf so that the
> URI disk profile adaptor can be customized to notify each resource
> provider with a different set of profiles.
>
>
> Diffs
> -----
>
> src/resource_provider/storage/disk_profile.proto 6cf1f8abcd24e45a292efc95a395f90bb2140da2
>
>
> Diff: https://reviews.apache.org/r/65538/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 65538: WIP: Added profile selectors in
`disk_profile.proto`.
Posted by James DeFelice <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65538/#review197063
-----------------------------------------------------------
Ship it!
Ship It!
- James DeFelice
On Feb. 7, 2018, 9:07 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65538/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2018, 9:07 p.m.)
>
>
> Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-8510
> https://issues.apache.org/jira/browse/MESOS-8510
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds two selectors to the `CSIManifest` protobuf so that the
> URI disk profile adaptor can be customized to notify each resource
> provider with a different set of profiles.
>
>
> Diffs
> -----
>
> src/resource_provider/storage/disk_profile.proto 6cf1f8abcd24e45a292efc95a395f90bb2140da2
>
>
> Diff: https://reviews.apache.org/r/65538/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 65538: Added resource provider selectors in
`disk_profile.proto`.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65538/#review197113
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Feb. 8, 2018, 4:36 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65538/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2018, 4:36 a.m.)
>
>
> Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-8510
> https://issues.apache.org/jira/browse/MESOS-8510
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds two selectors to the `CSIManifest` protobuf so that the
> URI disk profile adaptor can be customized to notify each resource
> provider with a different set of profiles.
>
>
> Diffs
> -----
>
> src/resource_provider/storage/disk_profile.proto 6cf1f8abcd24e45a292efc95a395f90bb2140da2
>
>
> Diff: https://reviews.apache.org/r/65538/diff/6/
>
>
> Testing
> -------
>
> Tests done later in chain.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 65538: Added resource provider selectors in
`disk_profile.proto`.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65538/
-----------------------------------------------------------
(Updated Feb. 8, 2018, 4:36 a.m.)
Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.
Summary (updated)
-----------------
Added resource provider selectors in `disk_profile.proto`.
Bugs: MESOS-8510
https://issues.apache.org/jira/browse/MESOS-8510
Repository: mesos
Description
-------
This patch adds two selectors to the `CSIManifest` protobuf so that the
URI disk profile adaptor can be customized to notify each resource
provider with a different set of profiles.
Diffs (updated)
-----
src/resource_provider/storage/disk_profile.proto 6cf1f8abcd24e45a292efc95a395f90bb2140da2
Diff: https://reviews.apache.org/r/65538/diff/6/
Changes: https://reviews.apache.org/r/65538/diff/5-6/
Testing
-------
Tests done later in chain.
Thanks,
Chun-Hung Hsiao
Re: Review Request 65538: WIP: Added profile selectors in
`disk_profile.proto`.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65538/
-----------------------------------------------------------
(Updated Feb. 7, 2018, 9:07 p.m.)
Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.
Changes
-------
Addressed Jie's comments.
Summary (updated)
-----------------
WIP: Added profile selectors in `disk_profile.proto`.
Bugs: MESOS-8510
https://issues.apache.org/jira/browse/MESOS-8510
Repository: mesos
Description (updated)
-------
This patch adds two selectors to the `CSIManifest` protobuf so that the
URI disk profile adaptor can be customized to notify each resource
provider with a different set of profiles.
Diffs (updated)
-----
src/resource_provider/storage/disk_profile.proto 6cf1f8abcd24e45a292efc95a395f90bb2140da2
Diff: https://reviews.apache.org/r/65538/diff/5/
Changes: https://reviews.apache.org/r/65538/diff/4-5/
Testing
-------
Thanks,
Chun-Hung Hsiao
Re: Review Request 65538: Added provider assignments into
`disk_profile.proto`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65538/#review197016
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 65520.
Failed command: `python.exe .\support\apply-reviews.py -n -r 65520`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65538
Relevant logs:
- [apply-review-65520-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65538/logs/apply-review-65520-stdout.log):
```
error: patch failed: src/tests/storage_local_resource_provider_tests.cpp:73
error: src/tests/storage_local_resource_provider_tests.cpp: patch does not apply
```
- Mesos Reviewbot Windows
On Feb. 7, 2018, 6:51 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65538/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2018, 6:51 p.m.)
>
>
> Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-8510
> https://issues.apache.org/jira/browse/MESOS-8510
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A new `assignments` field is added to the `DiskProfileMapping` protobuf
> so that the URI disk profile adaptor can be customized to notify each
> resource provider a different set of profiles.
>
>
> Diffs
> -----
>
> src/resource_provider/storage/disk_profile.proto 6cf1f8abcd24e45a292efc95a395f90bb2140da2
>
>
> Diff: https://reviews.apache.org/r/65538/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 65538: Added provider assignments into
`disk_profile.proto`.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65538/
-----------------------------------------------------------
(Updated Feb. 7, 2018, 6:51 p.m.)
Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.
Changes
-------
Addressed James' comment.
Summary (updated)
-----------------
Added provider assignments into `disk_profile.proto`.
Bugs: MESOS-8510
https://issues.apache.org/jira/browse/MESOS-8510
Repository: mesos
Description
-------
A new `assignments` field is added to the `DiskProfileMapping` protobuf
so that the URI disk profile adaptor can be customized to notify each
resource provider a different set of profiles.
Diffs (updated)
-----
src/resource_provider/storage/disk_profile.proto 6cf1f8abcd24e45a292efc95a395f90bb2140da2
Diff: https://reviews.apache.org/r/65538/diff/4/
Changes: https://reviews.apache.org/r/65538/diff/3-4/
Testing
-------
Thanks,
Chun-Hung Hsiao
Re: Review Request 65538: WIP: Added provider assignments into
`disk_profile.proto`.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65538/
-----------------------------------------------------------
(Updated Feb. 7, 2018, 1:12 a.m.)
Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.
Changes
-------
Addressed James' comment.
Bugs: MESOS-8510
https://issues.apache.org/jira/browse/MESOS-8510
Repository: mesos
Description
-------
A new `assignments` field is added to the `DiskProfileMapping` protobuf
so that the URI disk profile adaptor can be customized to notify each
resource provider a different set of profiles.
Diffs (updated)
-----
src/resource_provider/storage/disk_profile.proto 6cf1f8abcd24e45a292efc95a395f90bb2140da2
Diff: https://reviews.apache.org/r/65538/diff/3/
Changes: https://reviews.apache.org/r/65538/diff/2-3/
Testing
-------
Thanks,
Chun-Hung Hsiao
Re: Review Request 65538: WIP: Added provider assignments into
`disk_profile.proto`.
Posted by James DeFelice <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65538/#review196945
-----------------------------------------------------------
src/resource_provider/storage/disk_profile.proto
Lines 40 (patched)
<https://reviews.apache.org/r/65538/#comment276934>
Can we simplify this at all? It sounds like we're aiming for the following use cases:
1) no assignments: profiles apply to all providers
2) 1 or more assignments: each assignment links a provider to set of supported profiles
The first case already handled by leaving `resource_provider_assignments` unset. There's no need for special `*` syntax/handling. Let's get rid of support for snowflake names: both provider-identity fields are simply required for all ResourceProviderAssignment objects.
Also, please consider renaming `type` as `provider_type` and `name` as `provider_name` for clarity.
- James DeFelice
On Feb. 6, 2018, 11:36 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65538/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 11:36 p.m.)
>
>
> Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-8510
> https://issues.apache.org/jira/browse/MESOS-8510
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A new `assignments` field is added to the `DiskProfileMapping` protobuf
> so that the URI disk profile adaptor can be customized to notify each
> resource provider a different set of profiles.
>
>
> Diffs
> -----
>
> src/resource_provider/storage/disk_profile.proto 6cf1f8abcd24e45a292efc95a395f90bb2140da2
>
>
> Diff: https://reviews.apache.org/r/65538/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 65538: WIP: Added provider assignments into
`disk_profile.proto`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65538/#review196951
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['65032', '65471', '65472', '65060', '65499', '65520', '65534', '65523', '65521', '65061', '65522', '65538']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65538
Relevant logs:
- [mesos-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65538/logs/mesos-tests-cmake-stdout.log):
```
D:\DCOS\mesos\mesos\src\java\jni\convert.cpp(415): warning C4267: 'argument': conversion from 'size_t' to 'jsize', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
D:\DCOS\mesos\mesos\src\java\jni\convert.cpp(437): warning C4267: 'argument': conversion from 'size_t' to 'jsize', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
D:\DCOS\mesos\mesos\src\java\jni\convert.cpp(438): warning C4267: 'argument': conversion from 'size_t' to 'jsize', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
D:\DCOS\mesos\mesos\src\java\jni\convert.cpp(460): warning C4267: 'argument': conversion from 'size_t' to 'jsize', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
D:\DCOS\mesos\mesos\src\java\jni\convert.cpp(461): warning C4267: 'argument': conversion from 'size_t' to 'jsize', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
D:\DCOS\mesos\mesos\src\java\jni\convert.cpp(500): warning C4267: 'argument': conversion from 'size_t' to 'jsize', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
D:\DCOS\mesos\mesos\src\java\jni\convert.cpp(501): warning C4267: 'argument': conversion from 'size_t' to 'jsize', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
D:\DCOS\mesos\mesos\src\java\jni\org_apache_mesos_state_Variable.cpp(44): warning C4267: 'argument': conversion from 'size_t' to 'jsize', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
D:\DCOS\mesos\mesos\src\java\jni\org_apache_mesos_state_Variable.cpp(45): warning C4267: 'argument': conversion from 'size_t' to 'jsize', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
D:\DCOS\mesos\mesos\src\jvm\jvm.cpp(95): warning C4267: '=': conversion from 'size_t' to 'jint', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
D:\DCOS\mesos\mesos\src\jvm\jvm.cpp(463): warning C4244: 'initializing': conversion from 'jchar' to 'char', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
D:\DCOS\mesos\mesos\src\jvm\jvm.cpp(493): warning C4244: 'initializing': conversion from 'jlong' to 'long', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
D:\DCOS\mesos\mesos\src\jvm\jvm.cpp(654): warning C4244: 'initializing': conversion from 'jchar' to 'char', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
D:\DCOS\mesos\mesos\src\jvm\jvm.cpp(693): warning C4244: 'initializing': conversion from 'jlong' to 'long', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
D:\DCOS\mesos\mesos\src\jvm\jvm.cpp(770): warning C4244: 'initializing': conversion from 'jchar' to 'char', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
D:\DCOS\mesos\mesos\src\jvm\jvm.cpp(809): warning C4244: 'initializing': conversion from 'jlong' to 'long', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
"D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
(Link target) ->
cluster.obj : error LNK2019: unresolved external symbol "class Try<class std::list<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,class std::allocator<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > > >,class Error> __cdecl mesos::csi::paths::getContainerPaths(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &)" (?getContainerPaths@paths@csi@mesos@@YA?AV?$Try@V?$list@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@V?$allocator@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@2@@std@@VError@@@@AEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@00@Z) referenced in function "public: void __cdecl <lambda_ec4b6b812fb54f84d2a3b
9cb43048194>::operator()(void)const " (??R<lambda_ec4b6b812fb54f84d2a3b9cb43048194>@@QEBAXXZ) [D:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
cluster.obj : error LNK2019: unresolved external symbol "class Try<struct mesos::csi::paths::ContainerPath,class Error> __cdecl mesos::csi::paths::parseContainerPath(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &)" (?parseContainerPath@paths@csi@mesos@@YA?AV?$Try@UContainerPath@paths@csi@mesos@@VError@@@@AEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@0@Z) referenced in function "public: void __cdecl <lambda_ec4b6b812fb54f84d2a3b9cb43048194>::operator()(void)const " (??R<lambda_ec4b6b812fb54f84d2a3b9cb43048194>@@QEBAXXZ) [D:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
cluster.obj : error LNK2019: unresolved external symbol "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl mesos::csi::paths::getEndpointDirSymlinkPath(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class mesos::ContainerID const &)" (?getEndpointDirSymlinkPath@paths@csi@mesos@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV45@00AEBVContainerID@3@@Z) referenced in function "public: void __cdecl <lambda_ec4b6b812fb54f84d2a3b9cb43048194>::operator()(void)const " (??R<lambda_ec4b6b812fb54f84d2a3b9cb43048194>@@QEBAXXZ) [D:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
D:\DCOS\mesos\src\mesos-tests.exe : fatal error LNK1120: 3 unresolved externals [D:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
214 Warning(s)
4 Error(s)
Time Elapsed 00:27:49.67
```
- Mesos Reviewbot Windows
On Feb. 6, 2018, 11:36 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65538/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 11:36 p.m.)
>
>
> Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-8510
> https://issues.apache.org/jira/browse/MESOS-8510
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A new `assignments` field is added to the `DiskProfileMapping` protobuf
> so that the URI disk profile adaptor can be customized to notify each
> resource provider a different set of profiles.
>
>
> Diffs
> -----
>
> src/resource_provider/storage/disk_profile.proto 6cf1f8abcd24e45a292efc95a395f90bb2140da2
>
>
> Diff: https://reviews.apache.org/r/65538/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>