You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Lei Xu <le...@cloudera.com> on 2017/03/01 21:49:24 UTC
Review Request 57220: SENTRY-1638. Update MSentryPermChange table to
add a column for notification ID
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57220/
-----------------------------------------------------------
Review request for sentry and Hao Hao.
Bugs: SENTRY-1638
https://issues.apache.org/jira/browse/SENTRY-1638
Repository: sentry
Description
-------
This work is similar to SENTRY-1448, that adds a notification ID field in MSentryPermChange to be persistanted
Diffs
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPermChange.java 476fbcb2ad26de23757842111beb12b154e1562b
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo e981bcf0f327346c09cdbe5785fb8824fc62e704
Diff: https://reviews.apache.org/r/57220/diff/1/
Testing
-------
mvn clean package
Thanks,
Lei Xu
Re: Review Request 57220: SENTRY-1638. Update MSentryPermChange table
to add a column for notification ID
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57220/#review167584
-----------------------------------------------------------
Fix it, then Ship it!
Ship It!
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo
Lines 269 (patched)
<https://reviews.apache.org/r/57220/#comment239488>
Do we need to index by this column or enforce uniqueness?
- Alexander Kolbasov
On March 1, 2017, 9:49 p.m., Lei Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57220/
> -----------------------------------------------------------
>
> (Updated March 1, 2017, 9:49 p.m.)
>
>
> Review request for sentry and Hao Hao.
>
>
> Bugs: SENTRY-1638
> https://issues.apache.org/jira/browse/SENTRY-1638
>
>
> Repository: sentry
>
>
> Description
> -------
>
> This work is similar to SENTRY-1448, that adds a notification ID field in MSentryPermChange to be persistanted
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPermChange.java 476fbcb2ad26de23757842111beb12b154e1562b
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo e981bcf0f327346c09cdbe5785fb8824fc62e704
>
>
> Diff: https://reviews.apache.org/r/57220/diff/1/
>
>
> Testing
> -------
>
> mvn clean package
>
>
> Thanks,
>
> Lei Xu
>
>
Re: Review Request 57220: SENTRY-1638. Update MSentryPermChange table
to add a column for notification ID
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57220/#review167595
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Kolbasov
On March 1, 2017, 10:23 p.m., Lei Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57220/
> -----------------------------------------------------------
>
> (Updated March 1, 2017, 10:23 p.m.)
>
>
> Review request for sentry and Hao Hao.
>
>
> Bugs: SENTRY-1638
> https://issues.apache.org/jira/browse/SENTRY-1638
>
>
> Repository: sentry
>
>
> Description
> -------
>
> This work is similar to SENTRY-1448, that adds a notification ID field in MSentryPermChange to be persistanted
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPermChange.java 476fbcb2ad26de23757842111beb12b154e1562b
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo e981bcf0f327346c09cdbe5785fb8824fc62e704
>
>
> Diff: https://reviews.apache.org/r/57220/diff/2/
>
>
> Testing
> -------
>
> mvn clean package
>
>
> Thanks,
>
> Lei Xu
>
>
Re: Review Request 57220: SENTRY-1638. Update MSentryPermChange table
to add a column for notification ID
Posted by Lei Xu <le...@cloudera.com>.
> On March 2, 2017, 9:40 a.m., kalyan kumar kalvagadda wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo
> > Lines 287 (patched)
> > <https://reviews.apache.org/r/57220/diff/2/?file=1652981#file1652981line287>
> >
> > SENTRY-1638, need changes to sql script scripts for 5 different databases. What is the plan for that?
>
> Lei Xu wrote:
> I mis-understood the intention of this JIRA. This JIRA should be changing the 5 sql scripts for `MSentryPathChange`. I will do that in a new patch.
>
> kalyan kumar kalvagadda wrote:
> I will add required sql changes needed for notification id. I have jira SENTRY-1569 which handles the sql changes for SENTRY_PERM_CHANGE and SENTRY_PATH_CHANGE tables.
That'd be great. Thanks Kalyan! I will close this JIRA then.
Btw, Hao mentioned that only MSentryPathChange should have notification ID.
- Lei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57220/#review167691
-----------------------------------------------------------
On March 1, 2017, 2:23 p.m., Lei Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57220/
> -----------------------------------------------------------
>
> (Updated March 1, 2017, 2:23 p.m.)
>
>
> Review request for sentry and Hao Hao.
>
>
> Bugs: SENTRY-1638
> https://issues.apache.org/jira/browse/SENTRY-1638
>
>
> Repository: sentry
>
>
> Description
> -------
>
> This work is similar to SENTRY-1448, that adds a notification ID field in MSentryPermChange to be persistanted
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPermChange.java 476fbcb2ad26de23757842111beb12b154e1562b
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo e981bcf0f327346c09cdbe5785fb8824fc62e704
>
>
> Diff: https://reviews.apache.org/r/57220/diff/2/
>
>
> Testing
> -------
>
> mvn clean package
>
>
> Thanks,
>
> Lei Xu
>
>
Re: Review Request 57220: SENTRY-1638. Update MSentryPermChange table
to add a column for notification ID
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
> On March 2, 2017, 5:40 p.m., kalyan kumar kalvagadda wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo
> > Lines 287 (patched)
> > <https://reviews.apache.org/r/57220/diff/2/?file=1652981#file1652981line287>
> >
> > SENTRY-1638, need changes to sql script scripts for 5 different databases. What is the plan for that?
>
> Lei Xu wrote:
> I mis-understood the intention of this JIRA. This JIRA should be changing the 5 sql scripts for `MSentryPathChange`. I will do that in a new patch.
I will add required sql changes needed for notification id. I have jira SENTRY-1569 which handles the sql changes for SENTRY_PERM_CHANGE and SENTRY_PATH_CHANGE tables.
- kalyan kumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57220/#review167691
-----------------------------------------------------------
On March 1, 2017, 10:23 p.m., Lei Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57220/
> -----------------------------------------------------------
>
> (Updated March 1, 2017, 10:23 p.m.)
>
>
> Review request for sentry and Hao Hao.
>
>
> Bugs: SENTRY-1638
> https://issues.apache.org/jira/browse/SENTRY-1638
>
>
> Repository: sentry
>
>
> Description
> -------
>
> This work is similar to SENTRY-1448, that adds a notification ID field in MSentryPermChange to be persistanted
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPermChange.java 476fbcb2ad26de23757842111beb12b154e1562b
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo e981bcf0f327346c09cdbe5785fb8824fc62e704
>
>
> Diff: https://reviews.apache.org/r/57220/diff/2/
>
>
> Testing
> -------
>
> mvn clean package
>
>
> Thanks,
>
> Lei Xu
>
>
Re: Review Request 57220: SENTRY-1638. Update MSentryPermChange table
to add a column for notification ID
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
> On March 2, 2017, 5:40 p.m., kalyan kumar kalvagadda wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo
> > Lines 287 (patched)
> > <https://reviews.apache.org/r/57220/diff/2/?file=1652981#file1652981line287>
> >
> > SENTRY-1638, need changes to sql script scripts for 5 different databases. What is the plan for that?
>
> Lei Xu wrote:
> I mis-understood the intention of this JIRA. This JIRA should be changing the 5 sql scripts for `MSentryPathChange`. I will do that in a new patch.
>
> kalyan kumar kalvagadda wrote:
> I will add required sql changes needed for notification id. I have jira SENTRY-1569 which handles the sql changes for SENTRY_PERM_CHANGE and SENTRY_PATH_CHANGE tables.
>
> Lei Xu wrote:
> That'd be great. Thanks Kalyan! I will close this JIRA then.
>
> Btw, Hao mentioned that only MSentryPathChange should have notification ID.
That's true
- kalyan kumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57220/#review167691
-----------------------------------------------------------
On March 1, 2017, 10:23 p.m., Lei Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57220/
> -----------------------------------------------------------
>
> (Updated March 1, 2017, 10:23 p.m.)
>
>
> Review request for sentry and Hao Hao.
>
>
> Bugs: SENTRY-1638
> https://issues.apache.org/jira/browse/SENTRY-1638
>
>
> Repository: sentry
>
>
> Description
> -------
>
> This work is similar to SENTRY-1448, that adds a notification ID field in MSentryPermChange to be persistanted
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPermChange.java 476fbcb2ad26de23757842111beb12b154e1562b
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo e981bcf0f327346c09cdbe5785fb8824fc62e704
>
>
> Diff: https://reviews.apache.org/r/57220/diff/2/
>
>
> Testing
> -------
>
> mvn clean package
>
>
> Thanks,
>
> Lei Xu
>
>
Re: Review Request 57220: SENTRY-1638. Update MSentryPermChange table
to add a column for notification ID
Posted by Lei Xu <le...@cloudera.com>.
> On March 2, 2017, 9:40 a.m., kalyan kumar kalvagadda wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo
> > Lines 287 (patched)
> > <https://reviews.apache.org/r/57220/diff/2/?file=1652981#file1652981line287>
> >
> > SENTRY-1638, need changes to sql script scripts for 5 different databases. What is the plan for that?
I mis-understood the intention of this JIRA. This JIRA should be changing the 5 sql scripts for `MSentryPathChange`. I will do that in a new patch.
- Lei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57220/#review167691
-----------------------------------------------------------
On March 1, 2017, 2:23 p.m., Lei Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57220/
> -----------------------------------------------------------
>
> (Updated March 1, 2017, 2:23 p.m.)
>
>
> Review request for sentry and Hao Hao.
>
>
> Bugs: SENTRY-1638
> https://issues.apache.org/jira/browse/SENTRY-1638
>
>
> Repository: sentry
>
>
> Description
> -------
>
> This work is similar to SENTRY-1448, that adds a notification ID field in MSentryPermChange to be persistanted
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPermChange.java 476fbcb2ad26de23757842111beb12b154e1562b
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo e981bcf0f327346c09cdbe5785fb8824fc62e704
>
>
> Diff: https://reviews.apache.org/r/57220/diff/2/
>
>
> Testing
> -------
>
> mvn clean package
>
>
> Thanks,
>
> Lei Xu
>
>
Re: Review Request 57220: SENTRY-1638. Update MSentryPermChange table
to add a column for notification ID
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57220/#review167691
-----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo
Lines 287 (patched)
<https://reviews.apache.org/r/57220/#comment239600>
SENTRY-1638, need changes to sql script scripts for 5 different databases. What is the plan for that?
- kalyan kumar kalvagadda
On March 1, 2017, 10:23 p.m., Lei Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57220/
> -----------------------------------------------------------
>
> (Updated March 1, 2017, 10:23 p.m.)
>
>
> Review request for sentry and Hao Hao.
>
>
> Bugs: SENTRY-1638
> https://issues.apache.org/jira/browse/SENTRY-1638
>
>
> Repository: sentry
>
>
> Description
> -------
>
> This work is similar to SENTRY-1448, that adds a notification ID field in MSentryPermChange to be persistanted
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPermChange.java 476fbcb2ad26de23757842111beb12b154e1562b
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo e981bcf0f327346c09cdbe5785fb8824fc62e704
>
>
> Diff: https://reviews.apache.org/r/57220/diff/2/
>
>
> Testing
> -------
>
> mvn clean package
>
>
> Thanks,
>
> Lei Xu
>
>
Re: Review Request 57220: SENTRY-1638. Update MSentryPermChange table
to add a column for notification ID
Posted by Lei Xu <le...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57220/
-----------------------------------------------------------
(Updated March 1, 2017, 2:23 p.m.)
Review request for sentry and Hao Hao.
Changes
-------
Added index on both MSentryPermChange and MSentryPathChange.
Bugs: SENTRY-1638
https://issues.apache.org/jira/browse/SENTRY-1638
Repository: sentry
Description
-------
This work is similar to SENTRY-1448, that adds a notification ID field in MSentryPermChange to be persistanted
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPermChange.java 476fbcb2ad26de23757842111beb12b154e1562b
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo e981bcf0f327346c09cdbe5785fb8824fc62e704
Diff: https://reviews.apache.org/r/57220/diff/2/
Changes: https://reviews.apache.org/r/57220/diff/1-2/
Testing
-------
mvn clean package
Thanks,
Lei Xu