[GitHub] [beam] quentin-sommer commented on a change in pull request #15489: [BEAM-12865] Allow custom batch_duration in WriteToBigQuery

[GitBox <gi...@apache.org>]

quentin-sommer commented on a change in pull request #15489:
URL: https://github.com/apache/beam/pull/15489#discussion_r746911914



##########
File path: sdks/python/apache_beam/io/gcp/bigquery.py
##########
@@ -2158,7 +2169,7 @@ def expand(self, pcoll):
           schema=self.schema,
           create_disposition=self.create_disposition,
           write_disposition=self.write_disposition,
-          triggering_frequency=self.triggering_frequency,
+          triggering_frequency=int(self.triggering_frequency),

Review comment:
       I think it should be an integer. `BigQueryBatchFileLoads` uses it like this
   https://github.com/apache/beam/blob/8da177f64d314cf72e89a51e51fb0915f706a784/sdks/python/apache_beam/io/gcp/bigquery_file_loads.py#L873-L874
   
   [beam reference](https://beam.apache.org/releases/pydoc/2.33.0/apache_beam.transforms.trigger.html?highlight=trigger#apache_beam.transforms.trigger.AfterProcessingTime) states it's a second delay and I'm not sure what the implementation is doing so I'd rather be on the safe side and keep integers.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org