You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "zhijiang (Jira)" <ji...@apache.org> on 2020/01/07 02:33:00 UTC

[jira] [Updated] (FLINK-15021) Remove the setting of netty channel watermark in NettyServer

     [ https://issues.apache.org/jira/browse/FLINK-15021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

zhijiang updated FLINK-15021:
-----------------------------
    Summary: Remove the setting of netty channel watermark in NettyServer  (was: Remove setting of netty channel watermark and logic of writability changed)

> Remove the setting of netty channel watermark in NettyServer
> ------------------------------------------------------------
>
>                 Key: FLINK-15021
>                 URL: https://issues.apache.org/jira/browse/FLINK-15021
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Runtime / Network
>            Reporter: zhijiang
>            Assignee: zhijiang
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.11.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> The high and low watermark setting in NetterServer before was mainly used for network flow control and limiting the maximum memory overhead caused by copying data inside netty stack. In detail, when the downstream side processes slowly and exhausted the available buffers finally, it would temporarily close the auto read switch in netty stack. Then the upstream side would finally reach the high watermark of channel to become unwritable.
> But based on credit-based flow control and reusing flink network buffer inside netty stack, the watermark setting is not invalid now. So we can safely remove it to cleanup the codes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)