You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by atomtong <gi...@git.apache.org> on 2017/10/12 03:54:43 UTC
[GitHub] incubator-weex pull request #787: * [android] fix bug js console.log not bee...
GitHub user atomtong opened a pull request:
https://github.com/apache/incubator-weex/pull/787
* [android] fix bug js console.log not been print out
Android bugfix js log no print out 0.16
- [x] Make sure that you add at least one unit test for the bug which you had fixed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/atomtong/incubator-weex android-bugfix-jsLogNoPrintOut-0.16
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/787.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #787
----
commit 71a1c3206a3fa3de12c78719e8499dff099e0c66
Author: atomtong <to...@qq.com>
Date: 2017-10-12T03:44:50Z
* [android] fix bug js console.log not been print out
----
---
[GitHub] incubator-weex issue #787: * [android] fix bug js console.log not been print...
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/787
<!--
0 failure:
2 warning: No Changelog chan..., This PR should up...
1 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Warnings</th>
</tr>
</thead>
<tbody><tr>
<td>:warning:</td>
<td>No Changelog changes!</td>
</tr>
<tr>
<td>:warning:</td>
<td>This PR should update related documents as well. </td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>danger test finished.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
---
[GitHub] incubator-weex pull request #787: * [android] fix bug js console.log not bee...
Posted by atomtong <gi...@git.apache.org>.
GitHub user atomtong reopened a pull request:
https://github.com/apache/incubator-weex/pull/787
* [android] fix bug js console.log not been print out
Android bugfix js log no print out 0.16
- [x] Make sure that you add at least one unit test for the bug which you had fixed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/atomtong/incubator-weex android-bugfix-jsLogNoPrintOut-0.16
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/787.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #787
----
commit 71a1c3206a3fa3de12c78719e8499dff099e0c66
Author: atomtong <to...@qq.com>
Date: 2017-10-12T03:44:50Z
* [android] fix bug js console.log not been print out
----
---
[GitHub] incubator-weex pull request #787: * [android] fix bug js console.log not bee...
Posted by atomtong <gi...@git.apache.org>.
Github user atomtong closed the pull request at:
https://github.com/apache/incubator-weex/pull/787
---
[GitHub] incubator-weex issue #787: * [android] fix bug js console.log not been print...
Posted by gurisxie <gi...@git.apache.org>.
Github user gurisxie commented on the issue:
https://github.com/apache/incubator-weex/pull/787
@atomtong have a look!
com.taobao.weex.utils.WXUtilsTest > testGetIntWX FAILED
java.lang.RuntimeException: Method println in android.util.Log not mocked. See http://g.co/androidstudio/not-mocked for details.
at android.util.Log.println(Log.java)
at com.taobao.weex.utils.WXLogUtils.log(WXLogUtils.java:78)
at com.taobao.weex.utils.WXLogUtils.e(WXLogUtils.java:184)
at com.taobao.weex.utils.WXLogUtils.e(WXLogUtils.java:109)
at com.taobao.weex.utils.WXLogUtils.e(WXLogUtils.java:223)
at com.taobao.weex.utils.WXUtils.getInteger(WXUtils.java:241)
at com.taobao.weex.utils.WXUtils.getInt(WXUtils.java:203)
at com.taobao.weex.utils.WXUtilsTest.testGetIntWX(WXUtilsTest.java:156)
---
[GitHub] incubator-weex pull request #787: * [android] fix bug js console.log not bee...
Posted by atomtong <gi...@git.apache.org>.
Github user atomtong closed the pull request at:
https://github.com/apache/incubator-weex/pull/787
---