You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhay Kulkarni <ak...@hortonworks.com> on 2018/01/23 17:32:25 UTC

Review Request 65293: Simplify Ranger API for reporting results of access authorization

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65293/
-----------------------------------------------------------

Review request for ranger, Don Bosco Durai, Madhan Neethiraj, and Ramesh Mani.


Bugs: RANGER-1962
    https://issues.apache.org/jira/browse/RANGER-1962


Repository: ranger


Description
-------

Ranger reports results of access authorization to component using (at present) three different types of objects; DataMaskResult, RowFilterResult or AccessResult. It is desirable to unify this into one type for ease of maintenance of policy-engine, and adding more types of future queries that policy-engine may be tasked with.


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java 060b960 
  agents-common/src/main/java/org/apache/ranger/plugin/policyengine/PolicyEvaluatorForTag.java 0c91274 
  agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResult.java 28319b2 
  agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerDataMaskResult.java 2260c45 
  agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngine.java d9b0298 
  agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java cff7a5e 
  agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java 7077d7c 
  agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerRowFilterResult.java cd59a6d 
  agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultDataMaskPolicyItemEvaluator.java 45db7b0 
  agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java cbad651 
  agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyItemEvaluator.java c763cb5 
  agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultRowFilterPolicyItemEvaluator.java 365661b 
  agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerPolicyEvaluator.java 7165594 
  agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerPolicyItemEvaluator.java edbde29 
  agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java 4d3731b 
  agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java 9b4e3b9 
  agents-common/src/test/resources/policyengine/test_policyengine_hive_mask_filter.json d3e0c25 
  agents-common/src/test/resources/policyengine/test_policyengine_tag_hive_filebased.json 6b2863a 
  hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuditHandler.java 89bc0d8 
  hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java c131f02 
  ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestEngine.java 8d89794 
  ranger-tools/src/test/java/org/apache/ranger/policyengine/RangerPolicyEnginePerformanceTest.java 6b3fa06 
  security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 9d8f5d2 


Diff: https://reviews.apache.org/r/65293/diff/1/


Testing
-------

Passed all unit tests


Thanks,

Abhay Kulkarni


Re: Review Request 65293: Simplify Ranger API for reporting results of access authorization

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65293/#review196134
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On Jan. 23, 2018, 5:32 p.m., Abhay Kulkarni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65293/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2018, 5:32 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Madhan Neethiraj, and Ramesh Mani.
> 
> 
> Bugs: RANGER-1962
>     https://issues.apache.org/jira/browse/RANGER-1962
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Ranger reports results of access authorization to component using (at present) three different types of objects; DataMaskResult, RowFilterResult or AccessResult. It is desirable to unify this into one type for ease of maintenance of policy-engine, and adding more types of future queries that policy-engine may be tasked with.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java 060b960 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyengine/PolicyEvaluatorForTag.java 0c91274 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResult.java 28319b2 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerDataMaskResult.java 2260c45 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngine.java d9b0298 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java cff7a5e 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java 7077d7c 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerRowFilterResult.java cd59a6d 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultDataMaskPolicyItemEvaluator.java 45db7b0 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java cbad651 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyItemEvaluator.java c763cb5 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultRowFilterPolicyItemEvaluator.java 365661b 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerPolicyEvaluator.java 7165594 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerPolicyItemEvaluator.java edbde29 
>   agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java 4d3731b 
>   agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java 9b4e3b9 
>   agents-common/src/test/resources/policyengine/test_policyengine_hive_mask_filter.json d3e0c25 
>   agents-common/src/test/resources/policyengine/test_policyengine_tag_hive_filebased.json 6b2863a 
>   hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuditHandler.java 89bc0d8 
>   hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java c131f02 
>   ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestEngine.java 8d89794 
>   ranger-tools/src/test/java/org/apache/ranger/policyengine/RangerPolicyEnginePerformanceTest.java 6b3fa06 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 9d8f5d2 
> 
> 
> Diff: https://reviews.apache.org/r/65293/diff/1/
> 
> 
> Testing
> -------
> 
> Passed all unit tests
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>