You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "shreenidhiSaigaonkar (via GitHub)" <gi...@apache.org> on 2023/02/27 07:43:40 UTC
[GitHub] [hive] shreenidhiSaigaonkar opened a new pull request, #4084: HIVE-27107 : Fix improper metrics count for RESUME/RESET workflow
shreenidhiSaigaonkar opened a new pull request, #4084:
URL: https://github.com/apache/hive/pull/4084
### What changes were proposed in this pull request?
This patch fixes the improper metrics (TABLE count) incase of RESUME/RESET by taking intersection of tables in ```table_diff_complete``` and actual ```tables on source```.
### Why are the changes needed?
```REPL DUMP``` during RESET checks all the tables listed in ```table_diff_complete``` and persists
the table count in replication metrics. This is incorrect for RESET,
because table_diff_complete has those tables which needs to be dropped too.
### Does this PR introduce _any_ user-facing change?
NO
### How was this patch tested?
* Updated unit test for this scenario.
* Tested it in local setup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #4084: HIVE-27107 : Fix improper metrics count for RESUME/RESET workflow
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #4084:
URL: https://github.com/apache/hive/pull/4084#issuecomment-1445956466
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=4084)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4084&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4084&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4084&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4084&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4084&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4084&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4084&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4084&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4084&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4084&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4084&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4084&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4084&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4084&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pudidic merged pull request #4084: HIVE-27107 : Fix improper metrics count for RESUME/RESET workflow
Posted by "pudidic (via GitHub)" <gi...@apache.org>.
pudidic merged PR #4084:
URL: https://github.com/apache/hive/pull/4084
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pudidic commented on pull request #4084: HIVE-27107 : Fix improper metrics count for RESUME/RESET workflow
Posted by "pudidic (via GitHub)" <gi...@apache.org>.
pudidic commented on PR #4084:
URL: https://github.com/apache/hive/pull/4084#issuecomment-1461304559
LGTM +1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org