[GitHub] [geode] kirklund commented on a diff in pull request #7631: GEODE-10261: VMProvider.invokeAsync uses appropriate parameterization.

[GitBox <gi...@apache.org>]

kirklund commented on code in PR #7631:
URL: https://github.com/apache/geode/pull/7631#discussion_r865106529


##########
geode-dunit/src/distributedTest/java/org/apache/geode/test/dunit/tests/BasicDistributedTest.java:
##########
@@ -154,16 +156,18 @@ public void testRemoteInvokeAsync() throws Exception {
     String name = getUniqueName();
     String value = "Hello";
 
-    AsyncInvocation async1 = vm0.invokeAsync(() -> remoteBind(name, value)).join().checkException();
-    AsyncInvocation async2 =
-        vm0.invokeAsync(() -> remoteValidateBind(name, value)).join().checkException();
+    AsyncInvocation<Void> async1 =
+        vm0.<Void>invokeAsync(() -> remoteBind(name, value)).join().checkException();
+    AsyncInvocation<Void> async2 =
+        vm0.<Void>invokeAsync(() -> remoteValidateBind(name, value)).join().checkException();

Review Comment:
   Note: `join().checkException()` can and should always be replaced with `await()` instead.
   
   I'm not requesting changes... just a comment so you know.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org