You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Jake Farrell <jf...@apache.org> on 2014/06/25 22:18:10 UTC
Review Request 22983: AURORA-278 - Remove binaries from source RC
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22983/
-----------------------------------------------------------
Review request for Aurora, Dave Lester, Kevin Sweeney, and Bill Farner.
Bugs: AURORA-278
https://issues.apache.org/jira/browse/AURORA-278
Repository: aurora
Description
-------
AURORA-278 - Remove binaries from source RC
Diffs
-----
.auroraversion 0034eec93d9d40c8039735f01192121bd2edebea
.gitattributes PRE-CREATION
CHANGELOG e52a6ed3055c2deaca252de26f3c571cf0d629a7
build-support/release/changelog 5cc908fe1d5a0f39d626719634559e32508fc6cb
build-support/release/release 30fea493e33abad9acd98e35d60cf5287b9a0947
build-support/release/release-candidate 41d929f090ea376afb92f5edda697894d13f56db
Diff: https://reviews.apache.org/r/22983/diff/
Testing
-------
./builds-support/release/release-candidate -r 1 -l m
verified gig sig, md5, sha, untared release and looked for binary artifacts.
Additional review opened to address missing headers
Thanks,
Jake Farrell
Re: Review Request 22983: AURORA-278 - Remove binaries from source RC
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22983/#review47403
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On June 25, 2014, 1:18 p.m., Jake Farrell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22983/
> -----------------------------------------------------------
>
> (Updated June 25, 2014, 1:18 p.m.)
>
>
> Review request for Aurora, Dave Lester, Kevin Sweeney, and Bill Farner.
>
>
> Bugs: AURORA-278
> https://issues.apache.org/jira/browse/AURORA-278
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AURORA-278 - Remove binaries from source RC
>
>
> Diffs
> -----
>
> .auroraversion 0034eec93d9d40c8039735f01192121bd2edebea
> .gitattributes PRE-CREATION
> CHANGELOG e52a6ed3055c2deaca252de26f3c571cf0d629a7
> build-support/release/changelog 5cc908fe1d5a0f39d626719634559e32508fc6cb
> build-support/release/release 30fea493e33abad9acd98e35d60cf5287b9a0947
> build-support/release/release-candidate 41d929f090ea376afb92f5edda697894d13f56db
>
> Diff: https://reviews.apache.org/r/22983/diff/
>
>
> Testing
> -------
>
> ./builds-support/release/release-candidate -r 1 -l m
>
> verified gig sig, md5, sha, untared release and looked for binary artifacts.
>
> Additional review opened to address missing headers
>
>
> Thanks,
>
> Jake Farrell
>
>
Re: Review Request 22983: AURORA-278 - Remove binaries from source RC
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22983/#review46882
-----------------------------------------------------------
Ship it!
.gitattributes
<https://reviews.apache.org/r/22983/#comment82453>
Can you put a comment above, referencing AURORA-559 (just for some context).
- Bill Farner
On June 25, 2014, 8:18 p.m., Jake Farrell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22983/
> -----------------------------------------------------------
>
> (Updated June 25, 2014, 8:18 p.m.)
>
>
> Review request for Aurora, Dave Lester, Kevin Sweeney, and Bill Farner.
>
>
> Bugs: AURORA-278
> https://issues.apache.org/jira/browse/AURORA-278
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AURORA-278 - Remove binaries from source RC
>
>
> Diffs
> -----
>
> .auroraversion 0034eec93d9d40c8039735f01192121bd2edebea
> .gitattributes PRE-CREATION
> CHANGELOG e52a6ed3055c2deaca252de26f3c571cf0d629a7
> build-support/release/changelog 5cc908fe1d5a0f39d626719634559e32508fc6cb
> build-support/release/release 30fea493e33abad9acd98e35d60cf5287b9a0947
> build-support/release/release-candidate 41d929f090ea376afb92f5edda697894d13f56db
>
> Diff: https://reviews.apache.org/r/22983/diff/
>
>
> Testing
> -------
>
> ./builds-support/release/release-candidate -r 1 -l m
>
> verified gig sig, md5, sha, untared release and looked for binary artifacts.
>
> Additional review opened to address missing headers
>
>
> Thanks,
>
> Jake Farrell
>
>
Re: Review Request 22983: AURORA-278 - Remove binaries from source RC
Posted by Kevin Sweeney <ke...@apache.org>.
Sounds like committers came to a consensus in my absence so +1 to making
progress.
On Saturday, June 28, 2014, Jake Farrell <jf...@apache.org> wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22983/
>
> On June 27th, 2014, 6:01 p.m. UTC, *Kevin Sweeney* wrote:
>
> overall -1 to shipping as-is, since this will break tests in the source distribution
>
> Lets discuss this further at the monday meeting then
>
>
> - Jake
>
> On June 25th, 2014, 8:18 p.m. UTC, Jake Farrell wrote:
> Review request for Aurora, Dave Lester, Kevin Sweeney, and Bill Farner.
> By Jake Farrell.
>
> *Updated June 25, 2014, 8:18 p.m.*
> *Bugs: * AURORA-278 <https://issues.apache.org/jira/browse/AURORA-278>
> *Repository: * aurora
> Description
>
> AURORA-278 - Remove binaries from source RC
>
> Testing
>
> ./builds-support/release/release-candidate -r 1 -l m
>
> verified gig sig, md5, sha, untared release and looked for binary artifacts.
>
> Additional review opened to address missing headers
>
> Diffs
>
> - .auroraversion (0034eec93d9d40c8039735f01192121bd2edebea)
> - .gitattributes (PRE-CREATION)
> - CHANGELOG (e52a6ed3055c2deaca252de26f3c571cf0d629a7)
> - build-support/release/changelog
> (5cc908fe1d5a0f39d626719634559e32508fc6cb)
> - build-support/release/release
> (30fea493e33abad9acd98e35d60cf5287b9a0947)
> - build-support/release/release-candidate
> (41d929f090ea376afb92f5edda697894d13f56db)
>
> View Diff <https://reviews.apache.org/r/22983/diff/>
>
--
Sent from Gmail Mobile
Re: Review Request 22983: AURORA-278 - Remove binaries from source RC
Posted by Jake Farrell <jf...@apache.org>.
> On June 27, 2014, 6:01 p.m., Kevin Sweeney wrote:
> > overall -1 to shipping as-is, since this will break tests in the source distribution
Lets discuss this further at the monday meeting then
- Jake
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22983/#review46884
-----------------------------------------------------------
On June 25, 2014, 8:18 p.m., Jake Farrell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22983/
> -----------------------------------------------------------
>
> (Updated June 25, 2014, 8:18 p.m.)
>
>
> Review request for Aurora, Dave Lester, Kevin Sweeney, and Bill Farner.
>
>
> Bugs: AURORA-278
> https://issues.apache.org/jira/browse/AURORA-278
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AURORA-278 - Remove binaries from source RC
>
>
> Diffs
> -----
>
> .auroraversion 0034eec93d9d40c8039735f01192121bd2edebea
> .gitattributes PRE-CREATION
> CHANGELOG e52a6ed3055c2deaca252de26f3c571cf0d629a7
> build-support/release/changelog 5cc908fe1d5a0f39d626719634559e32508fc6cb
> build-support/release/release 30fea493e33abad9acd98e35d60cf5287b9a0947
> build-support/release/release-candidate 41d929f090ea376afb92f5edda697894d13f56db
>
> Diff: https://reviews.apache.org/r/22983/diff/
>
>
> Testing
> -------
>
> ./builds-support/release/release-candidate -r 1 -l m
>
> verified gig sig, md5, sha, untared release and looked for binary artifacts.
>
> Additional review opened to address missing headers
>
>
> Thanks,
>
> Jake Farrell
>
>
Re: Review Request 22983: AURORA-278 - Remove binaries from source RC
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22983/#review46884
-----------------------------------------------------------
overall -1 to shipping as-is, since this will break tests in the source distribution
- Kevin Sweeney
On June 25, 2014, 1:18 p.m., Jake Farrell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22983/
> -----------------------------------------------------------
>
> (Updated June 25, 2014, 1:18 p.m.)
>
>
> Review request for Aurora, Dave Lester, Kevin Sweeney, and Bill Farner.
>
>
> Bugs: AURORA-278
> https://issues.apache.org/jira/browse/AURORA-278
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AURORA-278 - Remove binaries from source RC
>
>
> Diffs
> -----
>
> .auroraversion 0034eec93d9d40c8039735f01192121bd2edebea
> .gitattributes PRE-CREATION
> CHANGELOG e52a6ed3055c2deaca252de26f3c571cf0d629a7
> build-support/release/changelog 5cc908fe1d5a0f39d626719634559e32508fc6cb
> build-support/release/release 30fea493e33abad9acd98e35d60cf5287b9a0947
> build-support/release/release-candidate 41d929f090ea376afb92f5edda697894d13f56db
>
> Diff: https://reviews.apache.org/r/22983/diff/
>
>
> Testing
> -------
>
> ./builds-support/release/release-candidate -r 1 -l m
>
> verified gig sig, md5, sha, untared release and looked for binary artifacts.
>
> Additional review opened to address missing headers
>
>
> Thanks,
>
> Jake Farrell
>
>
Re: Review Request 22983: AURORA-278 - Remove binaries from source RC
Posted by Jake Farrell <jf...@apache.org>.
> On June 25, 2014, 9:07 p.m., Bill Farner wrote:
> > .gitattributes, line 3
> > <https://reviews.apache.org/r/22983/diff/1/?file=617565#file617565line3>
> >
> > IIUC this will render a source distribution unusable, since many necessary files will be missing.
if i'm not mistaken /src/resources is only used for the e2e test, we need to come up with a way to auto generate those files if possible as they can not be included in the src release
- Jake
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22983/#review46679
-----------------------------------------------------------
On June 25, 2014, 8:18 p.m., Jake Farrell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22983/
> -----------------------------------------------------------
>
> (Updated June 25, 2014, 8:18 p.m.)
>
>
> Review request for Aurora, Dave Lester, Kevin Sweeney, and Bill Farner.
>
>
> Bugs: AURORA-278
> https://issues.apache.org/jira/browse/AURORA-278
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AURORA-278 - Remove binaries from source RC
>
>
> Diffs
> -----
>
> .auroraversion 0034eec93d9d40c8039735f01192121bd2edebea
> .gitattributes PRE-CREATION
> CHANGELOG e52a6ed3055c2deaca252de26f3c571cf0d629a7
> build-support/release/changelog 5cc908fe1d5a0f39d626719634559e32508fc6cb
> build-support/release/release 30fea493e33abad9acd98e35d60cf5287b9a0947
> build-support/release/release-candidate 41d929f090ea376afb92f5edda697894d13f56db
>
> Diff: https://reviews.apache.org/r/22983/diff/
>
>
> Testing
> -------
>
> ./builds-support/release/release-candidate -r 1 -l m
>
> verified gig sig, md5, sha, untared release and looked for binary artifacts.
>
> Additional review opened to address missing headers
>
>
> Thanks,
>
> Jake Farrell
>
>
Re: Review Request 22983: AURORA-278 - Remove binaries from source RC
Posted by Kevin Sweeney <ke...@apache.org>.
> On June 25, 2014, 2:07 p.m., Bill Farner wrote:
> > .gitattributes, line 3
> > <https://reviews.apache.org/r/22983/diff/1/?file=617565#file617565line3>
> >
> > IIUC this will render a source distribution unusable, since many necessary files will be missing.
>
> Jake Farrell wrote:
> if i'm not mistaken /src/resources is only used for the e2e test, we need to come up with a way to auto generate those files if possible as they can not be included in the src release
>
> Bill Farner wrote:
> Aha, my mistake - i was thinking of src/main/resources, this is src/resources, which is used by the python build. Filed https://issues.apache.org/jira/browse/AURORA-559 to put those in a conventional path.
src/resources is all test data for the executor. the binary files in here are tbinaryprotocol-serialized data used to test the executor's mechanism for communicating between processes. if we remove it then those tests will fail in the source distribution, which would mean a -1 to shipping.
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22983/#review46679
-----------------------------------------------------------
On June 25, 2014, 1:18 p.m., Jake Farrell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22983/
> -----------------------------------------------------------
>
> (Updated June 25, 2014, 1:18 p.m.)
>
>
> Review request for Aurora, Dave Lester, Kevin Sweeney, and Bill Farner.
>
>
> Bugs: AURORA-278
> https://issues.apache.org/jira/browse/AURORA-278
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AURORA-278 - Remove binaries from source RC
>
>
> Diffs
> -----
>
> .auroraversion 0034eec93d9d40c8039735f01192121bd2edebea
> .gitattributes PRE-CREATION
> CHANGELOG e52a6ed3055c2deaca252de26f3c571cf0d629a7
> build-support/release/changelog 5cc908fe1d5a0f39d626719634559e32508fc6cb
> build-support/release/release 30fea493e33abad9acd98e35d60cf5287b9a0947
> build-support/release/release-candidate 41d929f090ea376afb92f5edda697894d13f56db
>
> Diff: https://reviews.apache.org/r/22983/diff/
>
>
> Testing
> -------
>
> ./builds-support/release/release-candidate -r 1 -l m
>
> verified gig sig, md5, sha, untared release and looked for binary artifacts.
>
> Additional review opened to address missing headers
>
>
> Thanks,
>
> Jake Farrell
>
>
Re: Review Request 22983: AURORA-278 - Remove binaries from source RC
Posted by Bill Farner <wf...@apache.org>.
> On June 25, 2014, 9:07 p.m., Bill Farner wrote:
> > .gitattributes, line 3
> > <https://reviews.apache.org/r/22983/diff/1/?file=617565#file617565line3>
> >
> > IIUC this will render a source distribution unusable, since many necessary files will be missing.
>
> Jake Farrell wrote:
> if i'm not mistaken /src/resources is only used for the e2e test, we need to come up with a way to auto generate those files if possible as they can not be included in the src release
Aha, my mistake - i was thinking of src/main/resources, this is src/resources, which is used by the python build. Filed https://issues.apache.org/jira/browse/AURORA-559 to put those in a conventional path.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22983/#review46679
-----------------------------------------------------------
On June 25, 2014, 8:18 p.m., Jake Farrell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22983/
> -----------------------------------------------------------
>
> (Updated June 25, 2014, 8:18 p.m.)
>
>
> Review request for Aurora, Dave Lester, Kevin Sweeney, and Bill Farner.
>
>
> Bugs: AURORA-278
> https://issues.apache.org/jira/browse/AURORA-278
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AURORA-278 - Remove binaries from source RC
>
>
> Diffs
> -----
>
> .auroraversion 0034eec93d9d40c8039735f01192121bd2edebea
> .gitattributes PRE-CREATION
> CHANGELOG e52a6ed3055c2deaca252de26f3c571cf0d629a7
> build-support/release/changelog 5cc908fe1d5a0f39d626719634559e32508fc6cb
> build-support/release/release 30fea493e33abad9acd98e35d60cf5287b9a0947
> build-support/release/release-candidate 41d929f090ea376afb92f5edda697894d13f56db
>
> Diff: https://reviews.apache.org/r/22983/diff/
>
>
> Testing
> -------
>
> ./builds-support/release/release-candidate -r 1 -l m
>
> verified gig sig, md5, sha, untared release and looked for binary artifacts.
>
> Additional review opened to address missing headers
>
>
> Thanks,
>
> Jake Farrell
>
>
Re: Review Request 22983: AURORA-278 - Remove binaries from source RC
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22983/#review46679
-----------------------------------------------------------
.gitattributes
<https://reviews.apache.org/r/22983/#comment82220>
IIUC this will render a source distribution unusable, since many necessary files will be missing.
- Bill Farner
On June 25, 2014, 8:18 p.m., Jake Farrell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22983/
> -----------------------------------------------------------
>
> (Updated June 25, 2014, 8:18 p.m.)
>
>
> Review request for Aurora, Dave Lester, Kevin Sweeney, and Bill Farner.
>
>
> Bugs: AURORA-278
> https://issues.apache.org/jira/browse/AURORA-278
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AURORA-278 - Remove binaries from source RC
>
>
> Diffs
> -----
>
> .auroraversion 0034eec93d9d40c8039735f01192121bd2edebea
> .gitattributes PRE-CREATION
> CHANGELOG e52a6ed3055c2deaca252de26f3c571cf0d629a7
> build-support/release/changelog 5cc908fe1d5a0f39d626719634559e32508fc6cb
> build-support/release/release 30fea493e33abad9acd98e35d60cf5287b9a0947
> build-support/release/release-candidate 41d929f090ea376afb92f5edda697894d13f56db
>
> Diff: https://reviews.apache.org/r/22983/diff/
>
>
> Testing
> -------
>
> ./builds-support/release/release-candidate -r 1 -l m
>
> verified gig sig, md5, sha, untared release and looked for binary artifacts.
>
> Additional review opened to address missing headers
>
>
> Thanks,
>
> Jake Farrell
>
>