You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "ldrozdo (via GitHub)" <gi...@apache.org> on 2023/02/15 14:24:01 UTC
[GitHub] [camel-quarkus] ldrozdo opened a new pull request, #4578: Split json dataformats to different modules
ldrozdo opened a new pull request, #4578:
URL: https://github.com/apache/camel-quarkus/pull/4578
Fix #3088
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #4578: Split json dataformats to different modules
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on PR #4578:
URL: https://github.com/apache/camel-quarkus/pull/4578#issuecomment-1431962416
Looking the first check `validate PR Style / check-format (pull_request) `, reports `Some files do not have the expected license header`. It might be a matter of formatting, there are instructions that can be followed when creating a pr (commented in pr text content).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #4578: Split json dataformats to different modules
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on PR #4578:
URL: https://github.com/apache/camel-quarkus/pull/4578#issuecomment-1433113863
> @ldrozdo Could you please recall what ticket it is about ?
>
> By the way, we generally and up the commit message with #ticket number to find it easily.
Ok, it was mentioned in the first note. I've re-opened the ticket to include the jackson/jacksonxml split.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #4578: Split json dataformats to different modules
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on PR #4578:
URL: https://github.com/apache/camel-quarkus/pull/4578#issuecomment-1431970230
`group-07` tests are failing due to `Could not find the selected project in the reactor: integration-tests/dataformats-json`.
Was the project correctly renamed in `tooling/scripts/test-categories` ?
Keep up on this track. It's good to see progress :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ldrozdo commented on pull request #4578: Split json dataformats to different modules
Posted by "ldrozdo (via GitHub)" <gi...@apache.org>.
ldrozdo commented on PR #4578:
URL: https://github.com/apache/camel-quarkus/pull/4578#issuecomment-1431458714
Hi @ppalaga, @aldettinger , can you please review? I closed the previous PR because there were too many conflicts and it broke lot of the code.
One thing about this PR: I know that the classes in model could be extracted to `integration-tests-support`, but I tried it and I had some problems with native mode. I can play with it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #4578: Split json dataformats to different modules
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on PR #4578:
URL: https://github.com/apache/camel-quarkus/pull/4578#issuecomment-1433098855
@ldrozdo Could you please recall what ticket it is about ?
By the way, we generally and up the commit message with #ticket number to find it easily.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba commented on pull request #4578: Split json dataformats to different modules
Posted by "zbendhiba (via GitHub)" <gi...@apache.org>.
zbendhiba commented on PR #4578:
URL: https://github.com/apache/camel-quarkus/pull/4578#issuecomment-1464174793
Thanks @ldrozdo for your contribution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ldrozdo commented on pull request #4578: Split json dataformats to different modules
Posted by "ldrozdo (via GitHub)" <gi...@apache.org>.
ldrozdo commented on PR #4578:
URL: https://github.com/apache/camel-quarkus/pull/4578#issuecomment-1433058665
@aldettinger thank you! Yes, for sure we can split it, I will add it to my backlog :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger merged pull request #4578: Split json dataformats to different modules
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger merged PR #4578:
URL: https://github.com/apache/camel-quarkus/pull/4578
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org