You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "1996fanrui (via GitHub)" <gi...@apache.org> on 2024/04/11 10:08:08 UTC
[PR] [FLINK-35040] Revert `commons-io` to 2.11.0 [flink]
1996fanrui opened a new pull request, #24652:
URL: https://github.com/apache/flink/pull/24652
## What is the purpose of the change
The performance of serializerHeavyString regresses since April 3, and had not yet recovered on April 8th.
After running a series of benchmarks, I found [FLINK-34955](https://issues.apache.org/jira/browse/FLINK-34955) causes the performance regression.
FLINK-34955 wants to fix CVE issues of `common-compress`, but it upgrades the `commons-io` together. I try to revert `commons-io` to 2.11.0, and the performance is recovered.
## Brief change log
- [FLINK-35040] Revert `commons-io` to 2.11.0
- Revert part of `[FLINK-34955] Upgrade commons-compress to 1.26.0. (#24580)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-35040] Revert `commons-io` to 2.11.0 [flink]
Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui commented on PR #24652:
URL: https://github.com/apache/flink/pull/24652#issuecomment-2049377985
Thanks @slfan1989 for the quick review!
> @1996fanrui If we confirm that it's an issue with commons-io, couldn't we resolve it by upgrading commons-io instead?
Do you mean upgrading commons-io to the latest version? If yes, I tried upgrading `commons-io` to `2.16.1`, it doesn't work.
I saw `2.16.1` is the latest version of `commons-io`[1].
[1] https://mvnrepository.com/artifact/commons-io/commons-io
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-35040] Revert `commons-io` to 2.11.0 [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #24652:
URL: https://github.com/apache/flink/pull/24652#issuecomment-2049368111
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fbdcbb96a3d6cb0a766aef51eb332b8eb98f6759",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fbdcbb96a3d6cb0a766aef51eb332b8eb98f6759",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fbdcbb96a3d6cb0a766aef51eb332b8eb98f6759 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-35040] Revert `commons-io` to 2.11.0 [flink]
Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 commented on PR #24652:
URL: https://github.com/apache/flink/pull/24652#issuecomment-2049386534
> Thanks @slfan1989 for the quick review!
>
> > @1996fanrui If we confirm that it's an issue with commons-io, couldn't we resolve it by upgrading commons-io instead?
>
> Do you mean upgrading commons-io to the latest version? If yes, I tried upgrading `commons-io` to `2.16.1`, it doesn't work.
>
> I saw `2.16.1` is the latest version of `commons-io`[1].
>
> [1] https://mvnrepository.com/artifact/commons-io/commons-io
I'm sorry for any inconvenience caused. The reason for upgrading commons-io is that common-compress requires a higher version. We encounter a "class not found" issue when using commons-io 2.11. If we can't meet the performance requirements, I think we might have to revert FLINK-34955.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-35040] Revert `commons-io` to 2.11.0 [flink]
Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui commented on PR #24652:
URL: https://github.com/apache/flink/pull/24652#issuecomment-2105732689
It seems reverting it doesn't make sense, I close this PR first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-35040] Revert `commons-io` to 2.11.0 [flink]
Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 commented on PR #24652:
URL: https://github.com/apache/flink/pull/24652#issuecomment-2049370922
@1996fanrui If we confirm that it's an issue with commons-io, couldn't we resolve it by upgrading commons-io instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-35040] Revert `commons-io` to 2.11.0 [flink]
Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui closed pull request #24652: [FLINK-35040] Revert `commons-io` to 2.11.0
URL: https://github.com/apache/flink/pull/24652
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org