You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "kirklund (GitHub)" <gi...@apache.org> on 2019/09/25 23:02:48 UTC
[GitHub] [geode] kirklund opened pull request #4093: GEODE-7239:
Remove log4j-core from unit tests
Remove use of log4j-core from geode-core unit tests. GfshInitFileTest and ShowMissingDiskStoresFunctionTest had significant issues as tests so I nearly rewrote both.
1) Remove log4j-core from ColocationHelperTest
```
commit f9541824f8e015961f3b493ffd48c2fa0109648e
Author: Kirk Lund <kl...@apache.org>
Date: Tue Sep 24 14:26:50 2019 -0700
GEODE-7239: Remove log4j-core from ColocationHelperTest
* Remove log4j-core code
* Remove use of Fakes class
* Use MockitoRule with STRICT_STUBS
* Convert from JUnit Assert to AssertJ
* Use catchThrowable for expected exceptions
* Cleanup and streamline code
```
2) Rename GfshInitFileJUnitTest as GfshInitFileTest
```
commit d57d864150dd327166f2c66b512f2389d59a1b61
Author: Kirk Lund <kl...@apache.org>
Date: Tue Sep 24 14:30:05 2019 -0700
GEODE-7239: Rename GfshInitFileJUnitTest as GfshInitFileTest
```
3) Remove log4j-core from GfshInitFileTest
```
commit 0e5207bc76a272b603431eb7c779d8948f9b8872
Author: Kirk Lund <kl...@apache.org>
Date: Tue Sep 24 16:59:12 2019 -0700
GEODE-7239: Remove log4j-core from GfshInitFileTest
* Remove log4j-core code
* Move GfshConfig assertions to new GfshConfigTest
* Update from JUnit Assert to AssertJ
* Cleanup and streamline code
* Use clearer variable, field, and constant names
* Use updated test names
* Group tests into arrange/act/assert patterns
```
4) Rename ShowMissingDiskStoresFunctionTest
```
commit 8bfa634d2449c004b2b8ad55c1b08d1ba9bfd85c
Author: Kirk Lund <kl...@apache.org>
Date: Wed Sep 25 09:58:22 2019 -0700
GEODE-7239: Rename ShowMissingDiskStoresFunctionTest
Rename ShowMissingDiskStoresFunctionJUnitTest as
ShowMissingDiskStoresFunctionTest.
```
5) Remove log4j-core from ShowMissingDiskStoresFunctionTest
```
commit ea9604785310f1358f43b918fd447be45c272529
Author: Kirk Lund <kl...@apache.org>
Date: Wed Sep 25 14:51:23 2019 -0700
GEODE-7239: Remove log4j-core from ShowMissingDiskStoresFunctionTest
* Remove log4j-core code
* Extract FunctionContextImpl assertions to new FunctionContextImplTest
* Convert from JUnit Assert to AssertJ
* Use MockitoRule with STRICT_STUBS
* Fix generic typing as much as possible
* Organize tests by arrange, act, assert
* Add assertions to tests without any
* Fix variable names and strings
* Leverage AssertJ to reduce code
* Use modern test method names
* Use clearer variable, field, and constant names
* Cleanup and streamline code
```
[ Full content available at: https://github.com/apache/geode/pull/4093 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] kirklund commented on issue #4093: GEODE-7239:
Remove log4j-core from unit tests
Posted by "kirklund (GitHub)" <gi...@apache.org>.
@moleske I spent a bunch of time on the StressNewTestOpenJDK11 failure. Looks like GFSH itself is flaky and might take a looooong time to fix. It doesn't look like this test is "fixable" without tearing GFSH apart and putting it back together with bionics.
[ Full content available at: https://github.com/apache/geode/pull/4093 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] moleske commented on issue #4093: GEODE-7239: Remove
log4j-core from unit tests
Posted by "moleske (GitHub)" <gi...@apache.org>.
Sounds good to me, thanks for the update @kirklund !
[ Full content available at: https://github.com/apache/geode/pull/4093 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org