You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by "rahul37wallst-sudo (via GitHub)" <gi...@apache.org> on 2026/07/08 18:43:56 UTC

[PR] fix(line): keep labels above lines. close #15679 [echarts]

rahul37wallst-sudo opened a new pull request, #21682:
URL: https://github.com/apache/echarts/pull/21682

   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   Keeps line series paths below labels from mixed series by lowering the default line polyline `z2`.
   
   
   
   ### Fixed issues
   
   - #15679: Line graph overlaps labels on other series on mixed series.
   
   
   
   ## Details
   
   ### Before: What was the problem?
   
   In mixed charts such as bar + line, the line polyline used a default `z2` of `10`.
   
   That made the line path render above labels attached to other series, so a line series could visually overlap bar labels.
   
   
   
   ### After: How does it behave after the fixing?
   
   The line polyline default `z2` is lowered to `1`, so it no longer sits above labels from other series.
   
   A regression test was added to verify that a line polyline is rendered below a bar label in a mixed bar + line chart.
   
   
   
   ## Document Info
   
   One of the following should be checked.
   
   - [x] This PR doesn't relate to document changes
   - [ ] The document should be updated later
   - [ ] The document changes have been made in apache/echarts-doc#xxx
   
   
   
   ## Misc
   
   ### Security Checking
   
   - [ ] This PR uses security-sensitive Web APIs.
   
   <!-- PLEASE CHECK IT AGAINST: <https://github.com/apache/echarts/wiki/Security-Checklist-for-Code-Contributors> -->
   
   ### ZRender Changes
   
   - [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
   
   ### Related test cases or examples to use the new APIs
   
   - `test/ut/spec/series/line.test.ts`
   
   Validation run:
   
   - `npx jest --config test/ut/jest.config.cjs --coverage=false --runInBand --runTestsByPath test/ut/spec/series/line.test.ts`
   - `npm run lint`
   - `npm run checktype`
   - `npx eslint test/ut/spec/series/line.test.ts`
   - `git --no-pager diff --check`
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merging.
   
   ### Other information
   
   N.A.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org