You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Haisheng Yuan (JIRA)" <ji...@apache.org> on 2019/07/01 02:39:00 UTC
[jira] [Resolved] (CALCITE-3146) Support the detection of nested
aggregations for JdbcAggregate in SqlImplementor.
[ https://issues.apache.org/jira/browse/CALCITE-3146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Haisheng Yuan resolved CALCITE-3146.
------------------------------------
Resolution: Fixed
Fix Version/s: 1.21.0
Fixed in https://github.com/apache/calcite/commit/eb47b375c61aa4b3f6be2acb71e132c7a81c4e53, thanks for the PR, [~winipanda]!
> Support the detection of nested aggregations for JdbcAggregate in SqlImplementor.
> ---------------------------------------------------------------------------------
>
> Key: CALCITE-3146
> URL: https://issues.apache.org/jira/browse/CALCITE-3146
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.19.0
> Reporter: TANG Wen-hui
> Assignee: TANG Wen-hui
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.21.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The detection of nested aggregations in SqlImplementor.java is only for
> LogicalAggregate:
>
> {code:java}
> if (rel instanceof LogicalAggregate
> && !dialect.supportsNestedAggregations()
> && hasNestedAggregations((LogicalAggregate) rel)) {
> needNew = true;
> }
> {code}
> It should also support other sub-class of Aggregate such as JdbcAggregate .
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)