[GitHub] [superset] betodealmeida commented on a change in pull request #13185: chore: use shillelagh instead of gsheetsdb

[GitBox <gi...@apache.org>]

betodealmeida commented on a change in pull request #13185:
URL: https://github.com/apache/superset/pull/13185#discussion_r578580977



##########
File path: superset/views/core.py
##########
@@ -1234,7 +1231,7 @@ def testconn(  # pylint: disable=too-many-return-statements,no-self-use
         uri = request.json.get("uri")
         try:
             if app.config["PREVENT_UNSAFE_DB_CONNECTIONS"]:
-                check_sqlalchemy_uri(uri)
+                check_sqlalchemy_uri(make_url(uri))

Review comment:
       Me too.

##########
File path: setup.py
##########
@@ -129,7 +129,7 @@ def get_git_sha():
         "elasticsearch": ["elasticsearch-dbapi>=0.2.0, <0.3.0"],
         "exasol": ["sqlalchemy-exasol>=2.1.0, <2.2"],
         "excel": ["xlrd>=1.2.0, <1.3"],
-        "gsheets": ["gsheetsdb>=0.1.9"],
+        "gsheets": ["shillelagh>=0.2"],

Review comment:
       +1




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org