[GitHub] [pulsar] merlimat commented on a change in pull request #12175: [Python Schema] Support setting namespace for python schema

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #12175:
URL: https://github.com/apache/pulsar/pull/12175#discussion_r715797668



##########
File path: pulsar-client-cpp/python/pulsar/schema/definition.py
##########
@@ -101,15 +103,23 @@ def schema(cls):
 
     @classmethod
     def schema_info(cls, defined_names):
-        if cls.__name__ in defined_names:
-            return cls.__name__
+        namespace_prefix = ''
+        if cls._namespace is not None:
+            namespace_prefix = cls._namespace + '.'
+        namespace_name = namespace_prefix + cls.__name__
+
+        if namespace_name in defined_names:
+            return namespace_name
 
-        defined_names.add(cls.__name__)
+        defined_names.add(namespace_name)
         schema = {
             'name': str(cls.__name__),
+            'namespace': cls._namespace,
             'type': 'record',
             'fields': []
         }
+        if schema['namespace'] is None:
+            del schema['namespace']

Review comment:
       Instead of adding and then deleting, we could just add it only if it's not None

##########
File path: pulsar-client-cpp/python/pulsar/schema/definition.py
##########
@@ -57,6 +57,8 @@ def _get_fields(cls, dct):
 
 class Record(with_metaclass(RecordMeta, object)):
 
+    _namespace = None

Review comment:
       One other thing is that we should add this to the Python schema docs 

##########
File path: pulsar-client-cpp/python/pulsar/schema/definition.py
##########
@@ -57,6 +57,8 @@ def _get_fields(cls, dct):
 
 class Record(with_metaclass(RecordMeta, object)):
 
+    _namespace = None

Review comment:
       I was wondering given that this is very specific to Avro, if we should name it as `_avro_namespace` to make it clear.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org