You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jeff Coffler <je...@taltos.com> on 2017/05/15 22:42:12 UTC
Review Request 59297: Fix autotools to include ip.hpp & mac.hpp in
stout/{posix|windows}.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59297/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
Required since autotools includes .hpp files.
Diffs
-----
3rdparty/stout/include/Makefile.am ea4341b2dccc3d73b9d347d29486ab4c8ff42217
Diff: https://reviews.apache.org/r/59297/diff/1/
Testing
-------
This was an autotools-specific problem, I didn't catch this right away since my tests didn't build with autotools.
Now they do:
1. Autotools built successfully (cmake -j6 distcheck), and
2. Cmake built successfully (cmake -j6 check).
I'll be careful to check autotools in the future, particularly when adding files.
Note that a few lines had line continution not lining up. I resolved those for consistency with the rest of the file.
Thanks,
Jeff Coffler
Re: Review Request 59297: Fix autotools to include ip.hpp & mac.hpp in
stout/{posix|windows}.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59297/#review175130
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Schwartzmeyer
On May 15, 2017, 10:43 p.m., Jeff Coffler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59297/
> -----------------------------------------------------------
>
> (Updated May 15, 2017, 10:43 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.
>
>
> Bugs: MESOS-5938
> https://issues.apache.org/jira/browse/MESOS-5938
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Required since autotools includes .hpp files.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/Makefile.am ea4341b2dccc3d73b9d347d29486ab4c8ff42217
>
>
> Diff: https://reviews.apache.org/r/59297/diff/1/
>
>
> Testing
> -------
>
> This was an autotools-specific problem, I didn't catch this right away since my tests didn't build with autotools.
>
> Now they do:
>
> 1. Autotools built successfully (cmake -j6 distcheck), and
> 2. Cmake built successfully (cmake -j6 check).
>
> I'll be careful to check autotools in the future, particularly when adding files.
>
> Note that a few lines had line continution not lining up. I resolved those for consistency with the rest of the file.
>
>
> Thanks,
>
> Jeff Coffler
>
>
Re: Review Request 59297: Fix autotools to include ip.hpp & mac.hpp in
stout/{posix|windows}.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59297/#review175119
-----------------------------------------------------------
Patch looks great!
Reviews applied: [59200, 59201, 59202, 59203, 59297]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 15, 2017, 10:43 p.m., Jeff Coffler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59297/
> -----------------------------------------------------------
>
> (Updated May 15, 2017, 10:43 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.
>
>
> Bugs: MESOS-5938
> https://issues.apache.org/jira/browse/MESOS-5938
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Required since autotools includes .hpp files.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/Makefile.am ea4341b2dccc3d73b9d347d29486ab4c8ff42217
>
>
> Diff: https://reviews.apache.org/r/59297/diff/1/
>
>
> Testing
> -------
>
> This was an autotools-specific problem, I didn't catch this right away since my tests didn't build with autotools.
>
> Now they do:
>
> 1. Autotools built successfully (cmake -j6 distcheck), and
> 2. Cmake built successfully (cmake -j6 check).
>
> I'll be careful to check autotools in the future, particularly when adding files.
>
> Note that a few lines had line continution not lining up. I resolved those for consistency with the rest of the file.
>
>
> Thanks,
>
> Jeff Coffler
>
>
Re: Review Request 59297: Fix autotools to include ip.hpp & mac.hpp in
stout/{posix|windows}.
Posted by Jeff Coffler <je...@taltos.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59297/
-----------------------------------------------------------
(Updated May 15, 2017, 10:43 p.m.)
Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.
Changes
-------
Update bug number, reviewers
Bugs: MESOS-5938
https://issues.apache.org/jira/browse/MESOS-5938
Repository: mesos
Description
-------
Required since autotools includes .hpp files.
Diffs
-----
3rdparty/stout/include/Makefile.am ea4341b2dccc3d73b9d347d29486ab4c8ff42217
Diff: https://reviews.apache.org/r/59297/diff/1/
Testing
-------
This was an autotools-specific problem, I didn't catch this right away since my tests didn't build with autotools.
Now they do:
1. Autotools built successfully (cmake -j6 distcheck), and
2. Cmake built successfully (cmake -j6 check).
I'll be careful to check autotools in the future, particularly when adding files.
Note that a few lines had line continution not lining up. I resolved those for consistency with the rest of the file.
Thanks,
Jeff Coffler