[GitHub] [daffodil-vscode] stevedlawrence commented on pull request #51: License for distribution with vsix

[GitBox <gi...@apache.org>]

stevedlawrence commented on pull request #51:
URL: https://github.com/apache/daffodil-vscode/pull/51#issuecomment-975474825


   Latest updates looks really good. Thanks!
   
   However, while double checking things, I just noticed that the daffodil-debugger adds new dependencies on top of what Daffodil already requires:
   ```scala
         "ch.qos.logback" % "logback-classic" % "1.2.3",
         "com.microsoft.java" % "com.microsoft.java.debug.core" % "0.31.1",
         "co.fs2" %% "fs2-io" % "3.0.4",
         "com.monovore" %% "decline-effect" % "2.1.0",
         "org.typelevel" %% "log4cats-slf4j" % "2.1.0",
   ```
   I've briefly checked these licenses and I think they are acceptable to ASF (I haven't look at transitive dependencies, though), but we need to add references to all of these and the transitives in the `build/{LICENSE,NOTICE}` files since they end up in the distributed zip.
   
   Also note that I logback and microsoft-debug are EPL, which is fine for ASF but requires a mention in the README.
   
   https://www.apache.org/legal/resolved.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org