You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@royale.apache.org by Maria Jose Esteve <mj...@iest.com> on 2022/03/01 02:39:12 UTC
RE: Swc Compiler Version and Binary Reproducibility
Done. I hope I got it right š
Hiedra
-----Mensaje original-----
De: Yishay Weiss <yi...@hotmail.com>>
Enviado el: lunes, 28 de febrero de 2022 20:43
Para: dev@royale.apache.org<ma...@royale.apache.org>; Josh Tynjala <jo...@bowlerhat.dev>>
Asunto: RE: Swc Compiler Version and Binary Reproducibility
Looks like itās in ReleaseModules branch.
Maria, thanks for the list. Can you update <royale-asjs>/RELEASE_NOTES.md with those changes?
From: Alex Harui<ma...@adobe.com.INVALID>
Sent: Monday, February 28, 2022 7:29 PM
To: dev@royale.apache.org<ma...@royale.apache.org>>; Josh Tynjala<ma...@bowlerhat.dev>
Subject: Re: Swc Compiler Version and Binary Reproducibility
Did the modules stuff go in develop or in a branch?
ļ»æOn 2/28/22, 3:46 AM, "Yishay Weiss" <yi...@hotmail.com>> wrote:
Does anybody else want to add their changes? From memory, Harbs has made release optimizations and sanitizations, Alex has added support for modules in release, and Greg and Piotr have made various improvements in compiler and emulation.
Thanks.
From: Josh Tynjala<ma...@bowlerhat.dev>
Sent: Thursday, February 24, 2022 7:06 PM
To: Yishay Weiss<ma...@hotmail.com>
Cc: dev@royale.apache.org<ma...@royale.apache.org>>
Subject: Re: Swc Compiler Version and Binary Reproducibility
Sounds good. I've updated the release notes with summaries of my changes in 0.9.9.
--
Josh Tynjala
Bowler Hat LLC<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbowlerhat.dev%2F&data=04%7C01%7Caharui%40adobe.com%7C3dddec79abb44f8121b008d9faafca25%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637816455934671374%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=YSZGoU4tthUMzfnikCqsaMEqW%2B8gbjZBT%2BVNSc9rlB8%3D&reserved=0>
On Thu, Feb 24, 2022 at 1:09 AM Yishay Weiss <yi...@hotmail.com>>> wrote:
The effective pom for the CI swcs does show server version 0.9.8 which seems wrong. It could be I was doing something wrong on the CI.
I also had to update the years on NOTICE files and added my 0.9.9 changes to RELEASE_NOTES.md.
I think we need to update the rest of the RELEASE_NOTES files in the all repos, and when thatās done we can update the top level RELEASE_NOTES under royale-asjs\releasemgr\RELEASE_NOTES.
After thatās done Iāll start a new RC and will keep an eye on server versions for typedefs.
Thanks.
From: Yishay Weiss<ma...@hotmail.com>
Sent: Thursday, February 24, 2022 8:14 AM
To: Josh Tynjala<ma...@bowlerhat.dev>; Apache Royale Development<ma...@royale.apache.org>
Subject: RE: Swc Compiler Version and Binary Reproducibility
Ok, Iāll check that. Thanks for the explanation.
From: Josh Tynjala<ma...@bowlerhat.dev>
Sent: Wednesday, February 23, 2022 8:26 PM
To: Apache Royale Development<ma...@royale.apache.org>
Cc: yishayjobs@hotmail.com<ma...@hotmail.com>>>
Subject: Re: Swc Compiler Version and Binary Reproducibility
Could it be that the 8 and 9 are derived from the last part of Royale's recent version numbers: 0.9.8 and 0.9.9?
In your tutorialspoint link, it prints 1.6.0_25, so I can see why you think it might always be the Java version. However, I suspect that's specifically because tutorialspoint is calling getImplementationVersion() on the java.lang package, so the result will match whichever JDK it is from, since it is a core language class. I think that getImplementationVersion() is based on the version of the .jar file where the class/package is located. So, for Royale classes, it should return something like 0.9.8 or 0.9.9.
Anyway, it seems like the differing build numbers between CI and your local machine means that you have a different version of the compiler checked out locally than what the CI has.
--
Josh Tynjala
Bowler Hat LLC<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbowlerhat.dev%2F&data=04%7C01%7Caharui%40adobe.com%7C3dddec79abb44f8121b008d9faafca25%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637816455934671374%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=YSZGoU4tthUMzfnikCqsaMEqW%2B8gbjZBT%2BVNSc9rlB8%3D&reserved=0>
On Wed, Feb 23, 2022 at 10:04 AM Yishay Weiss <yi...@hotmail.com>>>> wrote:
The typedef swcs produced on my machine are different to the ones produced on CI which breaks the build process. I noticed this difference in the catalog (though itās not the only one)
<compiler name="Apache Royale: Compiler: Compiler-Common" version="0.9" build="8"/>
<compiler name="Apache Royale: Compiler: Compiler-Common" version="0.9" build="9"/>
Can somebody explain why the build# is different?
I had a look at SWCTarget.java in the compiler and it looks like itās getting its information from VersionInfo which ultimately relies on Javaās getImplementationVersion() [1].
I checked java -version both on my machine and on the CI and they both output 1.8.0_201, so I donāt understand why the version is different.
Any clues?
[1] Java.lang.getImplementationVersion() Method (tutorialspoint.com<https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Ftutorialspoint.com%2F&data=04%7C01%7Caharui%40adobe.com%7C3dddec79abb44f8121b008d9faafca25%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637816455934671374%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=QyrxqPTdJ7XyVJ9XjUNj5XZgavXjhky7EEpU86lqtto%3D&reserved=0><https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Ftutorialspoint.com%2F&data=04%7C01%7Caharui%40adobe.com%7C3dddec79abb44f8121b008d9faafca25%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637816455934671374%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=QyrxqPTdJ7XyVJ9XjUNj5XZgavXjhky7EEpU86lqtto%3D&reserved=0>)<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.tutorialspoint.com%2Fjava%2Flang%2Fpackage_getimplementationversion.htm&data=04%7C01%7Caharui%40adobe.com%7C3dddec79abb44f8121b008d9faafca25%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637816455934671374%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=pm9dUWczQOdfkmUXnMAhrIaj8UBXfl2Ic1hxNP45Q6Q%3D&reserved=0>