You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/08/31 16:39:12 UTC
[GitHub] [incubator-doris] xy720 opened a new pull request #4491: [Spark load][Bug] Fix column terminate for spark load
xy720 opened a new pull request #4491:
URL: https://github.com/apache/incubator-doris/pull/4491
## Proposed changes
fix #4490
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [x] Bugfix (non-breaking change which fixes an issue)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
- [x] Compiling and unit tests pass locally with my changes
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #4491: [Spark load][Bug] Fix column terminator for spark load
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #4491:
URL: https://github.com/apache/incubator-doris/pull/4491
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #4491: [Spark load][Bug] Fix column terminator for spark load
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #4491:
URL: https://github.com/apache/incubator-doris/pull/4491#discussion_r480726560
##########
File path: fe/spark-dpp/src/main/java/org/apache/doris/load/loadv2/etl/EtlJobConfig.java
##########
@@ -502,7 +504,7 @@ public EtlFileGroup(SourceType sourceType, List<String> filePaths, List<String>
this.filePaths = filePaths;
this.fileFieldNames = fileFieldNames;
this.columnsFromPath = columnsFromPath;
- this.columnSeparator = columnSeparator;
+ this.columnSeparator = Strings.isNullOrEmpty(columnSeparator)?'\t': columnSeparator.charAt(0);
Review comment:
```suggestion
this.columnSeparator = Strings.isNullOrEmpty(columnSeparator) ? '\t' : columnSeparator.charAt(0);
```
##########
File path: fe/spark-dpp/src/main/java/org/apache/doris/load/loadv2/dpp/SparkDpp.java
##########
@@ -559,7 +558,14 @@ private void processRollupTree(RollupTreeNode rootNode,
JavaRDD<Row> rowRDD = sourceDataRdd.flatMap(
record -> {
scannedRowsAcc.add(1);
- String[] attributes = record.split(fileGroup.columnSeparator);
+ char sep = fileGroup.columnSeparator;
Review comment:
Make it execute only once.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org