You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "gengliangwang (via GitHub)" <gi...@apache.org> on 2025/12/01 21:49:01 UTC

Re: [PR] [SPARK-53880][SQL] Fix DSv2 in PushVariantIntoScan by adding SupportsPushDownVariants [spark]

gengliangwang commented on PR #52578:
URL: https://github.com/apache/spark/pull/52578#issuecomment-3599106815

   There are a couple of issues with the new DSV2 rule SupportsPushDownVariants in this PR:
   	1.	The mix-in trait should override ScanBuilder rather than Scan for consistency.
   	2.	Variant type projections can only be fully pushed down or not pushed down at all. Since there are only two states, the API can be simplified to `boolean[] pushVariantProjections(VariantProjection[] projections);`.
   
   Given these issues, we should improve the API before 4.1 release.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org