[jira] [Closed] (FLINK-9761) Potential buffer leak in PartitionRequestClientHandler during job failures

["zhijiang (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/FLINK-9761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

zhijiang closed FLINK-9761.
---------------------------
    Resolution: Won't Fix

It was out of date. PartitionRequestClientHandler would not be used by default and be removed soon. So I closed this issue.

> Potential buffer leak in PartitionRequestClientHandler during job failures
> --------------------------------------------------------------------------
>
>                 Key: FLINK-9761
>                 URL: https://issues.apache.org/jira/browse/FLINK-9761
>             Project: Flink
>          Issue Type: Bug
>          Components: Runtime / Network
>    Affects Versions: 1.5.0
>            Reporter: Nico Kruber
>            Priority: Critical
>             Fix For: 1.6.5, 1.7.3
>
>
> {{PartitionRequestClientHandler#stagedMessages}} may be accessed from multiple threads:
> 1) Netty's IO thread
> 2) During cancellation, {{PartitionRequestClientHandler.BufferListenerTask#notifyBufferDestroyed}} is called
> If {{PartitionRequestClientHandler.BufferListenerTask#notifyBufferDestroyed}} thinks, {{stagesMessages}} is empty, however, it will not install the {{stagedMessagesHandler}} that consumes and releases buffers from received messages.
> Unless some unexpected combination of code calls prevents this from happening, this would leak the non-recycled buffers.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)