[GitHub] [incubator-pinot] chenboat commented on a change in pull request #6754: Add more logging for segment reloading status.

[GitBox <gi...@apache.org>]

chenboat commented on a change in pull request #6754:
URL: https://github.com/apache/incubator-pinot/pull/6754#discussion_r609160622



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/segment/index/loader/defaultcolumn/BaseDefaultColumnHandler.java
##########
@@ -133,6 +133,7 @@ public void updateDefaultColumns()
     // Compute the action needed for each column.
     Map<String, DefaultColumnAction> defaultColumnActionMap = computeDefaultColumnActionMap();
     if (defaultColumnActionMap.isEmpty()) {
+      LOGGER.info("No default column action needed for the segment {}.", _segmentMetadata.getName());

Review comment:
       updateDefaultColumn(...) does logging but it is buried in the calls. Fine for our needs now. Removed the line.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org