[GitHub] carbondata pull request #2647: [CARBONDATA-2872] Added Spark FileFormat inte...

[ravipesala <gi...@git.apache.org>]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2647#discussion_r212250447
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/readcommitter/LatestFilesReadCommittedScope.java ---
    @@ -66,7 +68,23 @@ public LatestFilesReadCommittedScope(String path, String segmentId) {
        * @param path carbon file path
        */
       public LatestFilesReadCommittedScope(String path) {
    -    this(path, null);
    +    this(path, (String) null);
    +  }
    +
    +  /**
    +   * a new constructor with path
    +   *
    +   * @param path carbon file path
    +   */
    +  public LatestFilesReadCommittedScope(String path, String[] subFolders) {
    +    Objects.requireNonNull(path);
    +    this.carbonFilePath = path;
    +    this.subFolders = subFolders;
    +    try {
    +      takeCarbonIndexFileSnapShot();
    +    } catch (IOException ex) {
    +      throw new RuntimeException("Error while taking index snapshot", ex);
    --- End diff --
    
    Not required handling here, so removed.


---