You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/07/01 23:13:50 UTC

Re: Review Request 12118: Removed bin/mesos-build-env.sh.in in favor of just putting flags in the bin/mesos-master.sh.in, bin/mesos-slave.sh.in, and bin/mesos-local.sh.in scripts since some binaries require different flags and they will fail on startup if they try and load an unknown flag.


> On June 27, 2013, 4:53 p.m., Ben Mahler wrote:
> > Can you update the README as well to remove the mention of mesos-build-env.sh.in?

Definitely, thanks for catching that Ben!


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12118/#review22470
-----------------------------------------------------------


On June 26, 2013, 8:58 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12118/
> -----------------------------------------------------------
> 
> (Updated June 26, 2013, 8:58 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We can't put flags that are not shared in mesos-build-env.sh. Thus, I don't see much value in having mesos-build-env.sh.in for only the "shared" flags since there are very few of these. Furthermore, I like the simplification of just looking in mesos-slave.sh.in or mesos-master.sh.in, etc. to see exactly what flags are getting set.
> 
> 
> Diffs
> -----
> 
>   bin/mesos-build-env.sh.in f2bbe42997007adc4b342991210067218b807d09 
>   bin/mesos-local.sh.in 2ac67898cd99d56039dbb5d2c9876259ec7b1dd8 
>   bin/mesos-master.sh.in fa9f139ba7678b24f366813ccea00af8dbf33000 
>   bin/mesos-slave.sh.in 0384bcb8151bdfea4b99ebee8116172f27a8ae93 
>   bin/mesos-tests.sh.in 8d19556cefd55175d20f69f30efc2e2d884d5460 
>   configure.ac fbe22e5772502ef3d9bea7b58b323881a51934ab 
> 
> Diff: https://reviews.apache.org/r/12118/diff/
> 
> 
> Testing
> -------
> 
> ./bin/mesos-master.sh
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>