You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/02/11 22:19:36 UTC
[kudu-CR](branch-1.9.x) KUDU-2411: Exclude libz from binary jar on macOS
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12448
Change subject: KUDU-2411: Exclude libz from binary jar on macOS
......................................................................
KUDU-2411: Exclude libz from binary jar on macOS
macOS ships with a version of libz in /usr/lib so we should use that
instead in order to avoid ABI incompatibility with system libraries.
This is to address the following error observed when someone with an
older macOS version built a binary jar and it was tested on a newer
macOS version:
dyld: Symbol not found: _inflateValidate
Referenced from: /System/Library/Frameworks/ImageIO.framework/Versions/A/Resources/libPng.dylib
Expected in: /private/var/folders/80/kr312hd50c16mf7k1xm0fnv80000gp/T/kudu-binary-jar4282159433165606863/kudu-binary-1.9.0-osx-x86_64/bin/../lib/libz.1.dylib
in /System/Library/Frameworks/ImageIO.framework/Versions/A/Resources/libPng.dylib
Change-Id: I2f0862cd949da1466704011a6f3517eb49418570
Reviewed-on: http://gerrit.cloudera.org:8080/12444
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Grant Henke <gr...@apache.org>
(cherry picked from commit 626938ed8b9a5bcfe2c1c4a6be44af81f1eafb6b)
---
M build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/12448/1
--
To view, visit http://gerrit.cloudera.org:8080/12448
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.9.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2f0862cd949da1466704011a6f3517eb49418570
Gerrit-Change-Number: 12448
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR](branch-1.9.x) KUDU-2411: Exclude libz from binary jar on macOS
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12448 )
Change subject: KUDU-2411: Exclude libz from binary jar on macOS
......................................................................
KUDU-2411: Exclude libz from binary jar on macOS
macOS ships with a version of libz in /usr/lib so we should use that
instead in order to avoid ABI incompatibility with system libraries.
This is to address the following error observed when someone with an
older macOS version built a binary jar and it was tested on a newer
macOS version:
dyld: Symbol not found: _inflateValidate
Referenced from: /System/Library/Frameworks/ImageIO.framework/Versions/A/Resources/libPng.dylib
Expected in: /private/var/folders/80/kr312hd50c16mf7k1xm0fnv80000gp/T/kudu-binary-jar4282159433165606863/kudu-binary-1.9.0-osx-x86_64/bin/../lib/libz.1.dylib
in /System/Library/Frameworks/ImageIO.framework/Versions/A/Resources/libPng.dylib
Change-Id: I2f0862cd949da1466704011a6f3517eb49418570
Reviewed-on: http://gerrit.cloudera.org:8080/12444
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Grant Henke <gr...@apache.org>
(cherry picked from commit 626938ed8b9a5bcfe2c1c4a6be44af81f1eafb6b)
Reviewed-on: http://gerrit.cloudera.org:8080/12448
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Kudu Jenkins: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12448
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.9.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I2f0862cd949da1466704011a6f3517eb49418570
Gerrit-Change-Number: 12448
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR](branch-1.9.x) KUDU-2411: Exclude libz from binary jar on macOS
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12448 )
Change subject: KUDU-2411: Exclude libz from binary jar on macOS
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12448
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.9.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0862cd949da1466704011a6f3517eb49418570
Gerrit-Change-Number: 12448
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 12 Feb 2019 01:28:19 +0000
Gerrit-HasComments: No