You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@streampipes.apache.org by ze...@apache.org on 2022/08/01 16:10:40 UTC

[incubator-streampipes] 03/05: [hotfix] Fix dashboard cypress test

This is an automated email from the ASF dual-hosted git repository.

zehnder pushed a commit to branch STREAMPIPES-545
in repository https://gitbox.apache.org/repos/asf/incubator-streampipes.git

commit fe05a0343116556481ebc921762e40a65ee3dc43
Author: Philipp Zehnder <ze...@fzi.de>
AuthorDate: Mon Aug 1 16:47:58 2022 +0200

    [hotfix] Fix dashboard cypress test
---
 ui/cypress/support/utils/ConnectUtils.ts             | 14 ++++++++++----
 .../tests/dashboard/dashboardTest.smoke.spec.ts      | 20 ++------------------
 .../add-visualization-dialog.component.html          |  2 +-
 3 files changed, 13 insertions(+), 23 deletions(-)

diff --git a/ui/cypress/support/utils/ConnectUtils.ts b/ui/cypress/support/utils/ConnectUtils.ts
index f2a39dfd7..8589ce597 100644
--- a/ui/cypress/support/utils/ConnectUtils.ts
+++ b/ui/cypress/support/utils/ConnectUtils.ts
@@ -94,13 +94,19 @@ export class ConnectUtils {
     ConnectEventSchemaUtils.finishEventSchemaConfiguration();
   }
 
-  public static addMachineDataSimulator(name: string) {
+  public static addMachineDataSimulator(name: string, persist: boolean = false) {
 
-    const configuration = SpecificAdapterBuilder
+    const builder = SpecificAdapterBuilder
       .create('Machine_Data_Simulator')
       .setName(name)
-      .addInput('input', 'wait-time-ms', '1000')
-      .build();
+      .addInput('input', 'wait-time-ms', '1000');
+
+    if (persist) {
+      builder.setTimestampProperty('timestamp').
+                setStoreInDataLake();
+    }
+
+    const configuration = builder.build();
 
     ConnectUtils.goToConnect();
 
diff --git a/ui/cypress/tests/dashboard/dashboardTest.smoke.spec.ts b/ui/cypress/tests/dashboard/dashboardTest.smoke.spec.ts
index dd8eabf48..be6ad80a0 100644
--- a/ui/cypress/tests/dashboard/dashboardTest.smoke.spec.ts
+++ b/ui/cypress/tests/dashboard/dashboardTest.smoke.spec.ts
@@ -17,31 +17,15 @@
  */
 
 import { ConnectUtils } from '../../support/utils/ConnectUtils';
-import { PipelineUtils } from '../../support/utils/PipelineUtils';
-import { PipelineElementBuilder } from '../../support/builder/PipelineElementBuilder';
-import { PipelineBuilder } from '../../support/builder/PipelineBuilder';
 import { DashboardUtils } from '../../support/utils/DashboardUtils';
 
-const adapterName = 'simulator';
-
-
 describe('Test live dashboard', () => {
   beforeEach('Setup Test', () => {
     cy.initStreamPipesTest();
-    ConnectUtils.addMachineDataSimulator(adapterName);
+    ConnectUtils.addMachineDataSimulator('simulator', true);
   });
 
   it('Perform Test', () => {
-    const pipelineName = 'DashboardPipeline';
-    const pipelineInput = PipelineBuilder.create(pipelineName)
-      .addSource(adapterName)
-      .addSink(
-        PipelineElementBuilder.create('data_lake')
-          .addInput('input', 'db_measurement', 'demo')
-          .build())
-      .build();
-
-    PipelineUtils.testPipeline(pipelineInput);
 
     DashboardUtils.goToDashboard();
 
@@ -49,7 +33,7 @@ describe('Test live dashboard', () => {
     const dashboardName = 'testDashboard';
     DashboardUtils.addAndEditDashboard(dashboardName);
 
-    DashboardUtils.addWidget(pipelineName, 'raw');
+    DashboardUtils.addWidget('Persist_simulator', 'raw');
 
     // Validate that data is coming (at least 3 events)
     DashboardUtils.validateRawWidgetEvents(3);
diff --git a/ui/src/app/dashboard/dialogs/add-widget/add-visualization-dialog.component.html b/ui/src/app/dashboard/dialogs/add-widget/add-visualization-dialog.component.html
index 45c650a29..5142e8c6c 100644
--- a/ui/src/app/dashboard/dialogs/add-widget/add-visualization-dialog.component.html
+++ b/ui/src/app/dashboard/dialogs/add-widget/add-visualization-dialog.component.html
@@ -26,7 +26,7 @@
                         <mat-list-item *ngFor="let pipeline of visualizablePipelines"
                                        (click)="selectPipeline(pipeline)"
                                        class="list-item"
-                                        [attr.data-cy]="'dashboard-visualize-pipeline-' + pipeline.pipelineName">
+                                        [attr.data-cy]="'dashboard-visualize-pipeline-' + pipeline.pipelineName.replaceAll(' ', '_')">
                             <div mat-list-avatar
                                  class="pipeline-avatar sp-accent-bg">{{iconText(pipeline.measureName)}}
                             </div>