You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gaston Kleiman <ga...@mesosphere.io> on 2017/10/02 23:11:13 UTC

Review Request 62739: Added a test using DefaultExecutor + health check + persistent volume.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62739/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov, Greg Mann, and Vinod Kone.


Bugs: MESOS-7916
    https://issues.apache.org/jira/browse/MESOS-7916


Repository: mesos


Description
-------

This test verifies that the command health checks initiated by the
default executor are able to read files in a persistent volume.


Diffs
-----

  src/tests/default_executor_tests.cpp 63952d97b76c3e16973705cb0b16140dd381b7ce 


Diff: https://reviews.apache.org/r/62739/diff/1/


Testing
-------

`sudo GLOG_v=1 bin/mesos-tests.sh --gtest_filter="*ROOT_HealthCheckUsingPersistentVolume*" --verbose --gtest_repeat=250 --gtest_break_on_failure` on GNU/Linux


Thanks,

Gaston Kleiman


Re: Review Request 62739: Added a test using DefaultExecutor + health check + persistent volume.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62739/#review186921
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On Oct. 2, 2017, 11:11 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62739/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2017, 11:11 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-7916
>     https://issues.apache.org/jira/browse/MESOS-7916
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test verifies that the command health checks initiated by the
> default executor are able to read files in a persistent volume.
> 
> 
> Diffs
> -----
> 
>   src/tests/default_executor_tests.cpp 63952d97b76c3e16973705cb0b16140dd381b7ce 
> 
> 
> Diff: https://reviews.apache.org/r/62739/diff/1/
> 
> 
> Testing
> -------
> 
> `sudo GLOG_v=1 bin/mesos-tests.sh --gtest_filter="*ROOT_HealthCheckUsingPersistentVolume*" --verbose --gtest_repeat=250 --gtest_break_on_failure` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Re: Review Request 62739: Added a test using DefaultExecutor + health check + persistent volume.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62739/#review186939
-----------------------------------------------------------



Patch looks great!

Reviews applied: [62739]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Oct. 2, 2017, 11:11 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62739/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2017, 11:11 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-7916
>     https://issues.apache.org/jira/browse/MESOS-7916
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test verifies that the command health checks initiated by the
> default executor are able to read files in a persistent volume.
> 
> 
> Diffs
> -----
> 
>   src/tests/default_executor_tests.cpp 63952d97b76c3e16973705cb0b16140dd381b7ce 
> 
> 
> Diff: https://reviews.apache.org/r/62739/diff/1/
> 
> 
> Testing
> -------
> 
> `sudo GLOG_v=1 bin/mesos-tests.sh --gtest_filter="*ROOT_HealthCheckUsingPersistentVolume*" --verbose --gtest_repeat=250 --gtest_break_on_failure` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Re: Review Request 62739: Added a test using DefaultExecutor + health check + persistent volume.

Posted by Vinod Kone <vi...@gmail.com>.

> On Oct. 2, 2017, 11:21 p.m., Vinod Kone wrote:
> > src/tests/default_executor_tests.cpp
> > Lines 2392 (patched)
> > <https://reviews.apache.org/r/62739/diff/1/?file=1842582#file1842582line2392>
> >
> >     what's the guarantee that by the time health check command runs this file exists?
> 
> Gaston Kleiman wrote:
>     The interval/grace period settings bellow will make the executor ignore failures for the first 10 seconds and retry the check without waiting.
>     
>     My guess was that 10 seconds should be enough for the task to create the file, but we can make the grace period a bit longer.

So if the check passes within a few seconds, we still get an update right away and not wait for the whole 10s right?


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62739/#review186910
-----------------------------------------------------------


On Oct. 2, 2017, 11:11 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62739/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2017, 11:11 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-7916
>     https://issues.apache.org/jira/browse/MESOS-7916
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test verifies that the command health checks initiated by the
> default executor are able to read files in a persistent volume.
> 
> 
> Diffs
> -----
> 
>   src/tests/default_executor_tests.cpp 63952d97b76c3e16973705cb0b16140dd381b7ce 
> 
> 
> Diff: https://reviews.apache.org/r/62739/diff/1/
> 
> 
> Testing
> -------
> 
> `sudo GLOG_v=1 bin/mesos-tests.sh --gtest_filter="*ROOT_HealthCheckUsingPersistentVolume*" --verbose --gtest_repeat=250 --gtest_break_on_failure` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Re: Review Request 62739: Added a test using DefaultExecutor + health check + persistent volume.

Posted by Gaston Kleiman <ga...@mesosphere.io>.

> On Oct. 2, 2017, 4:21 p.m., Vinod Kone wrote:
> > src/tests/default_executor_tests.cpp
> > Lines 2392 (patched)
> > <https://reviews.apache.org/r/62739/diff/1/?file=1842582#file1842582line2392>
> >
> >     what's the guarantee that by the time health check command runs this file exists?
> 
> Gaston Kleiman wrote:
>     The interval/grace period settings bellow will make the executor ignore failures for the first 10 seconds and retry the check without waiting.
>     
>     My guess was that 10 seconds should be enough for the task to create the file, but we can make the grace period a bit longer.
> 
> Vinod Kone wrote:
>     So if the check passes within a few seconds, we still get an update right away and not wait for the whole 10s right?

Right, the executor will send an update with `healthy=true` as soon as a check passes.


- Gaston


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62739/#review186910
-----------------------------------------------------------


On Oct. 2, 2017, 4:11 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62739/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2017, 4:11 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-7916
>     https://issues.apache.org/jira/browse/MESOS-7916
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test verifies that the command health checks initiated by the
> default executor are able to read files in a persistent volume.
> 
> 
> Diffs
> -----
> 
>   src/tests/default_executor_tests.cpp 63952d97b76c3e16973705cb0b16140dd381b7ce 
> 
> 
> Diff: https://reviews.apache.org/r/62739/diff/1/
> 
> 
> Testing
> -------
> 
> `sudo GLOG_v=1 bin/mesos-tests.sh --gtest_filter="*ROOT_HealthCheckUsingPersistentVolume*" --verbose --gtest_repeat=250 --gtest_break_on_failure` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Re: Review Request 62739: Added a test using DefaultExecutor + health check + persistent volume.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62739/#review186910
-----------------------------------------------------------




src/tests/default_executor_tests.cpp
Lines 2392 (patched)
<https://reviews.apache.org/r/62739/#comment263793>

    what's the guarantee that by the time health check command runs this file exists?


- Vinod Kone


On Oct. 2, 2017, 11:11 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62739/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2017, 11:11 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-7916
>     https://issues.apache.org/jira/browse/MESOS-7916
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test verifies that the command health checks initiated by the
> default executor are able to read files in a persistent volume.
> 
> 
> Diffs
> -----
> 
>   src/tests/default_executor_tests.cpp 63952d97b76c3e16973705cb0b16140dd381b7ce 
> 
> 
> Diff: https://reviews.apache.org/r/62739/diff/1/
> 
> 
> Testing
> -------
> 
> `sudo GLOG_v=1 bin/mesos-tests.sh --gtest_filter="*ROOT_HealthCheckUsingPersistentVolume*" --verbose --gtest_repeat=250 --gtest_break_on_failure` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Re: Review Request 62739: Added a test using DefaultExecutor + health check + persistent volume.

Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62739/#review186911
-----------------------------------------------------------




src/tests/default_executor_tests.cpp
Lines 2392 (patched)
<https://reviews.apache.org/r/62739/#comment263802>

    The interval/grace period settings bellow will make the executor ignore failures for the first 10 seconds and retry the check without waiting.
    
    My guess was that 10 seconds should be enough for the task to create the file, but we can make the grace period a bit longer.


- Gaston Kleiman


On Oct. 2, 2017, 4:11 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62739/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2017, 4:11 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-7916
>     https://issues.apache.org/jira/browse/MESOS-7916
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test verifies that the command health checks initiated by the
> default executor are able to read files in a persistent volume.
> 
> 
> Diffs
> -----
> 
>   src/tests/default_executor_tests.cpp 63952d97b76c3e16973705cb0b16140dd381b7ce 
> 
> 
> Diff: https://reviews.apache.org/r/62739/diff/1/
> 
> 
> Testing
> -------
> 
> `sudo GLOG_v=1 bin/mesos-tests.sh --gtest_filter="*ROOT_HealthCheckUsingPersistentVolume*" --verbose --gtest_repeat=250 --gtest_break_on_failure` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Re: Review Request 62739: Added a test using DefaultExecutor + health check + persistent volume.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62739/#review186923
-----------------------------------------------------------



PASS: Mesos patch 62739 was successfully built and tested.

Reviews applied: `['62739']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62739

- Mesos Reviewbot Windows


On Oct. 2, 2017, 11:11 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62739/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2017, 11:11 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-7916
>     https://issues.apache.org/jira/browse/MESOS-7916
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test verifies that the command health checks initiated by the
> default executor are able to read files in a persistent volume.
> 
> 
> Diffs
> -----
> 
>   src/tests/default_executor_tests.cpp 63952d97b76c3e16973705cb0b16140dd381b7ce 
> 
> 
> Diff: https://reviews.apache.org/r/62739/diff/1/
> 
> 
> Testing
> -------
> 
> `sudo GLOG_v=1 bin/mesos-tests.sh --gtest_filter="*ROOT_HealthCheckUsingPersistentVolume*" --verbose --gtest_repeat=250 --gtest_break_on_failure` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>