You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "Startrekzky (via GitHub)" <gi...@apache.org> on 2023/05/08 02:54:43 UTC
[GitHub] [incubator-devlake] Startrekzky opened a new issue, #4745: [Feature][Data Schema] Add an `original_status` field to table pull_requests and use `status` to indicate standardized statuses
Startrekzky opened a new issue, #4745:
URL: https://github.com/apache/incubator-devlake/issues/4745
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/incubator-devlake/issues?q=is%3Aissue) and found no similar feature requirement.
### Use case
DevLake has to standardize pull request statuses from GitHub, GitLab, and BitBucket to **provide pre-defined PR/MR metrics** in dashboards such as Engineering Overview, as the queries in this dashboard should clearly define which PR is open, merged, or closed in any potential tools.
However, if DevLake transformed the original PR statuses into standardized statuses, users might be confused as the standardized values are different from the original ones.
Therefore, both the original and standardized value of PR statuses need to save in table.pull_requests.
### Description
There should be three possible values of `status` in pull_requests. All PR/MRs from GitHub, GitLab, BitBucket, and Azure Repo should be transformed into these values:
- OPEN
- MERGED
- CLOSED
For BitBucket PRs:
- BitBucket `OPEN` -> OPEN
- BitBucket `MERGED` -> MERGED
- BitBucket `DECLINED` -> CLOSED
For GitHub PRs from RESTful:
- GitHub `OPEN` -> OPEN
- GitHub `CLOSED` and merged_date is not null -> MERGED
- GitHub `CLOSED` and merged_date is null -> CLOSED
For GitHub PRs from GraphQL:
- GitHub `OPEN` -> OPEN
- GitHub `MERGED` -> MERGED
- GitHub `CLOSED` -> CLOSED
For GitLab PRs:
- GitLab `opened` -> OPEN
- GitLab `merged` -> MERGED
- GitLab `closed` or `locked` -> CLOSED
For Azure PRs (refer to [this doc](https://learn.microsoft.com/en-us/azure/devops/repos/git/pull-request-status?view=azure-devops#pull-request-status), can you please help verify this? @CamilleTeruel ):
- Azure `pending` or 'notSet' or 'notApplicable' -> OPEN
- Azure `succeeded` -> MERGED
- Azure `failed` or `error` -> CLOSED
To Do:
- [ ] Add an `original_status` field to table pull_requests to save the original PR/MR status
- [ ] Convert each tool's original PR/MR statuses to standardized statuses and save them to the field `status` in table pull_requests based on the above rules.
- [ ] Check if dashboards that contain PR-status-realated metrics are affected by this change. For example, GitHub, GitLab, BitBucket, and Engineering Overview dashboard, etc.
- [ ] Update the [pull_request description](https://devlake.apache.org/docs/DataModels/DevLakeDomainLayerSchema#pull_requests) in the schema doc with the above rules.
### Related issues
_No response_
### Are you willing to submit a PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] yumengwang03 closed issue #4745: [Feature][Data Schema] Add an `original_status` field to table pull_requests and use `status` to indicate standardized statuses
Posted by "yumengwang03 (via GitHub)" <gi...@apache.org>.
yumengwang03 closed issue #4745: [Feature][Data Schema] Add an `original_status` field to table pull_requests and use `status` to indicate standardized statuses
URL: https://github.com/apache/incubator-devlake/issues/4745
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] github-actions[bot] commented on issue #4745: [Feature][Data Schema] Add an `original_status` field to table pull_requests and use `status` to indicate standardized statuses
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #4745:
URL: https://github.com/apache/incubator-devlake/issues/4745#issuecomment-1518438726
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] Startrekzky commented on issue #4745: [Feature][Data Schema] Add an `original_status` field to table pull_requests and use `status` to indicate standardized statuses
Posted by "Startrekzky (via GitHub)" <gi...@apache.org>.
Startrekzky commented on issue #4745:
URL: https://github.com/apache/incubator-devlake/issues/4745#issuecomment-1541924770
@CamilleTeruel Are these all Azure PR statuses? I noticed that there're statuses like 'pending', 'failed', 'error' in the Azure API docs. Have we standardized them or keep the original values?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] CamilleTeruel commented on issue #4745: [Feature][Data Schema] Add an `original_status` field to table pull_requests and use `status` to indicate standardized statuses
Posted by "CamilleTeruel (via GitHub)" <gi...@apache.org>.
CamilleTeruel commented on issue #4745:
URL: https://github.com/apache/incubator-devlake/issues/4745#issuecomment-1541786798
> For Azure PRs (refer to [this doc](https://learn.microsoft.com/en-us/azure/devops/repos/git/pull-request-status?view=azure-devops#pull-request-status), can you please help verify this? @CamilleTeruel ):
> * Azure `pending` or 'notSet' or 'notApplicable' -> OPEN
> * Azure `succeeded` -> MERGED
> * Azure `failed` or `error` -> CLOSED
The azure statuses we get from API are described [here](https://learn.microsoft.com/en-us/rest/api/azure/devops/git/pull-requests/get-pull-request?view=azure-devops-rest-7.1#pullrequeststatus)
Currently we have:
- Azure `active` -> OPEN
- Azure `completed` -> MERGED
- Azure `abandoned` -> CLOSED
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] github-actions[bot] closed issue #4745: [Feature][Data Schema] Add an `original_status` field to table pull_requests and use `status` to indicate standardized statuses
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #4745: [Feature][Data Schema] Add an `original_status` field to table pull_requests and use `status` to indicate standardized statuses
URL: https://github.com/apache/incubator-devlake/issues/4745
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] github-actions[bot] commented on issue #4745: [Feature][Data Schema] Add an `original_status` field to table pull_requests and use `status` to indicate standardized statuses
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #4745:
URL: https://github.com/apache/incubator-devlake/issues/4745#issuecomment-1530647451
This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] CamilleTeruel commented on issue #4745: [Feature][Data Schema] Add an `original_status` field to table pull_requests and use `status` to indicate standardized statuses
Posted by "CamilleTeruel (via GitHub)" <gi...@apache.org>.
CamilleTeruel commented on issue #4745:
URL: https://github.com/apache/incubator-devlake/issues/4745#issuecomment-1541975036
> @CamilleTeruel Are these all Azure PR statuses?
There is also `all` and `notSet`. `all` is just used as a a query parameter for searching PRs and `notSet` is mapped to `None` but I never met it in real world data.
> I noticed that there're statuses like 'pending', 'failed', and 'error' as described in the Azure API docs. Have we standardized them or kept the original values?
Those are the original values.
The `pending`, `failed`, and `error` are not values of the same concept of "status".
Confusingly, there are two things that are called PR status in azure devops:
- there is the `status` property of pull requests objects you get from `_apis/git/repositories/{repositoryId}/pullrequests` which tell whether a PR is open ("active") closed ("abandonned") or merged ("completed"). This is the one we are interested in here.
- there are the values that a third party CI tool can attach to a PR that is accessible from `/_apis/git/repositories/{repositoryId}/pullRequests/{pullRequestId}/statuses` that we don't collect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] Startrekzky commented on issue #4745: [Feature][Data Schema] Add an `original_status` field to table pull_requests and use `status` to indicate standardized statuses
Posted by "Startrekzky (via GitHub)" <gi...@apache.org>.
Startrekzky commented on issue #4745:
URL: https://github.com/apache/incubator-devlake/issues/4745#issuecomment-1543728452
That's very clear. Thank you, @CamilleTeruel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] Startrekzky commented on issue #4745: [Feature][Data Schema] Add an `original_status` field to table pull_requests and use `status` to indicate standardized statuses
Posted by "Startrekzky (via GitHub)" <gi...@apache.org>.
Startrekzky commented on issue #4745:
URL: https://github.com/apache/incubator-devlake/issues/4745#issuecomment-1613443192
I tested the PR statues with the SQL below:
```
SELECT distinct SUBSTRING_INDEX(id,':',1) as source, status, original_status FROM pull_requests
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org