[GitHub] [spark] 10110346 commented on a change in pull request #24446: [SPARK-27552][SQL]The configuration `hive.exec.stagingdir` is invalid on Windows OS

[GitBox <gi...@apache.org>]

10110346 commented on a change in pull request #24446: [SPARK-27552][SQL]The configuration `hive.exec.stagingdir` is invalid on Windows OS
URL: https://github.com/apache/spark/pull/24446#discussion_r281472311
 
 

 ##########
 File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/SaveAsHiveFile.scala
 ##########
 @@ -219,7 +219,7 @@ private[hive] trait SaveAsHiveFile extends DataWritingCommand {
     val fs: FileSystem = inputPath.getFileSystem(hadoopConf)
     var stagingPathName: String =
       if (inputPathName.indexOf(stagingDir) == -1) {
-        new Path(inputPathName, stagingDir).toString
+        new Path(inputPathName, stagingDir).toUri.getPath
 
 Review comment:
   >  add a set of tests
   
   Sorry for the late reply. 
   I'll try to add some unit tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org