[GitHub] storm pull request #2648: STORM-3013: Keep KafkaConsumer open when storm-kaf...

[srdo <gi...@git.apache.org>]

GitHub user srdo opened a pull request:

    https://github.com/apache/storm/pull/2648

    STORM-3013: Keep KafkaConsumer open when storm-kafka-client spout is …

    …deactivated, in order to keep metrics working
    
    See https://issues.apache.org/jira/browse/STORM-3013
    
    The changes here are to fix a crash that occur if the spout is deactivated and Storm asks for metrics. The KafkaConsumer is closed when the spout deactivates, and the metrics provider tries to use the consumer to generate a few metrics.
    
    The suggested fix is to not close the KafkaConsumer when deactivating the spout. There's no real reason to do it as far as I can tell, and having to replace the consumer makes the spout a bit more complex than it would otherwise be.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/srdo/storm STORM-3013

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2648.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2648
    
----
commit ca506b82149745fdada5d4e9a6d41eaf958a8459
Author: Stig Rohde Døssing <sr...@...>
Date:   2018-03-30T17:12:01Z

    STORM-3013: Keep KafkaConsumer open when storm-kafka-client spout is deactivated, in order to keep metrics working

----


---

[GitHub] storm pull request #2648: STORM-3013: Keep KafkaConsumer open when storm-kaf...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/2648


---

[GitHub] storm issue #2648: STORM-3013: Keep KafkaConsumer open when storm-kafka-clie...

[HeartSaVioR <gi...@git.apache.org>]

Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/2648
  
    @srdo 
    The patch wasn't applied to 1.x-branch cleanly. Could you please raise a PR for 1.x-branch as well? Thanks in advance!


---