You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by jsirois <gi...@git.apache.org> on 2016/02/13 05:09:50 UTC
[GitHub] thrift pull request: THRIFT-3626 Fix lib/cpp/test/TSocketInterrupt...
GitHub user jsirois opened a pull request:
https://github.com/apache/thrift/pull/857
THRIFT-3626 Fix lib/cpp/test/TSocketInterruptTest.cpp to use ephemera…
…l ports.
Instead of using a fixed port, use an ephemeral port to improve
robustness and make way for parallelizability.
This change has an undesirable amount of repeated code but this fact is
not different from the prior so being a bit expedient here. Ideally
setup of a `TServerSocket` listening on an ephemeral port would be DRYed
up into a helper of some sort.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jsirois/thrift THRIFT-3626
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/857.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #857
----
commit aae84b40a7ff3a78b06b02efc4c2c744251914ea
Author: John Sirois <js...@apache.org>
Date: 2016-02-13T04:07:49Z
THRIFT-3626 Fix lib/cpp/test/TSocketInterruptTest.cpp to use ephemeral ports.
Instead of using a fixed port, use an ephemeral port to improve
robustness and make way for parallelizability.
This change has an undesirable amount of repeated code but this fact is
not different from the prior so being a bit expedient here. Ideally
setup of a `TServerSocket` listening on an ephemeral port would be DRYed
up into a helper of some sort.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3626 Fix lib/cpp/test/TSocketInterrupt...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/857
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---