[jira] [Reopened] (KAFKA-683) Fix correlation ids in all requests sent to kafka

["Jay Kreps (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/KAFKA-683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jay Kreps reopened KAFKA-683:
-----------------------------


Guys, this patch adds request specific stuff to RequestChannel. RequestChannel is really not the place to be parsing out various kafka api fields. The network package is not supposed to have ANY kafka-specific logic in it and doing this in the request channel . Moving request parsing to the network threads is also not what we want, I think. I'm pretty frustrated because I keep spending time taking this stuff out and people keep adding it back in. I'm the maintainer for this package so I would really like to be added on review for it.
</end_rant>
                
> Fix correlation ids in all requests sent to kafka
> -------------------------------------------------
>
>                 Key: KAFKA-683
>                 URL: https://issues.apache.org/jira/browse/KAFKA-683
>             Project: Kafka
>          Issue Type: Improvement
>    Affects Versions: 0.8
>            Reporter: Neha Narkhede
>            Assignee: Neha Narkhede
>            Priority: Critical
>              Labels: improvement, replication
>         Attachments: kafka-683-v1.patch, kafka-683-v2.patch, kafka-683-v2-rebased.patch, kafka-683-v2-rebased-twice.patch, kafka-683-v3.patch, kafka-683-v3-unit-test.patch
>
>
> We should fix the correlation ids in every request sent to Kafka and fix the request log on the broker to specify not only the type of request and who sent it, but also the correlation id. This will be very helpful while troubleshooting problems in production.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira