You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/01/14 06:06:23 UTC
[GitHub] [apisix] bisakhmondal opened a new pull request #6103: chore: streamline error checking process
bisakhmondal opened a new pull request #6103:
URL: https://github.com/apache/apisix/pull/6103
Signed-off-by: Bisakh Mondal <bi...@gmail.com>
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
https://github.com/apache/apisix/pull/6037#discussion_r779988474
### Pre-submission checklist:
<!--
Please follow the PR manners:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. If you need to resolve merge conflicts after the PR is reviewed, please merge master but do not rebase
6. Use "request review" to notify the reviewer once you have resolved the review
7. Only reviewer can click "Resolve conversation" to mark the reviewer's review resolved
-->
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #6103: chore: streamline error checking process
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on a change in pull request #6103:
URL: https://github.com/apache/apisix/pull/6103#discussion_r785262673
##########
File path: t/plugin/basic-auth.t
##########
@@ -398,7 +398,7 @@ GET /t
-=== TEST 15: enable basic auth plugin using admin api, set hide_credentials = true
+=== TEST 18: enable basic auth plugin using admin api, set hide_credentials = true
Review comment:
Need to fetch the latest code for the master branch, which has been fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #6103: chore: streamline error checking process
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #6103:
URL: https://github.com/apache/apisix/pull/6103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bisakhmondal commented on a change in pull request #6103: chore: streamline error checking process
Posted by GitBox <gi...@apache.org>.
bisakhmondal commented on a change in pull request #6103:
URL: https://github.com/apache/apisix/pull/6103#discussion_r785299031
##########
File path: apisix/plugins/openid-connect.lua
##########
@@ -293,30 +293,28 @@ function _M.rewrite(plugin_conf, ctx)
-- the configured redirect URI after successful authentication.
response, err = openidc.authenticate(conf)
- if err then
+ if not response then
Review comment:
Thanks. Updated
##########
File path: t/plugin/basic-auth.t
##########
@@ -398,7 +398,7 @@ GET /t
-=== TEST 15: enable basic auth plugin using admin api, set hide_credentials = true
+=== TEST 18: enable basic auth plugin using admin api, set hide_credentials = true
Review comment:
Done. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #6103: chore: streamline error checking process
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #6103:
URL: https://github.com/apache/apisix/pull/6103#discussion_r785262618
##########
File path: apisix/plugins/openid-connect.lua
##########
@@ -293,30 +293,28 @@ function _M.rewrite(plugin_conf, ctx)
-- the configured redirect URI after successful authentication.
response, err = openidc.authenticate(conf)
- if err then
+ if not response then
Review comment:
the openidc returns non-nil err to indicate something wrong, see:
https://github.com/zmartzone/lua-resty-openidc#sample-configuration-for-google-signin
https://github.com/zmartzone/lua-resty-openidc/blob/master/lib/resty/openidc.lua#L1494
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org