You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by iyovcheva <gi...@git.apache.org> on 2015/08/10 14:21:23 UTC
[GitHub] incubator-brooklyn pull request: Renaming packages logback-include...
GitHub user iyovcheva opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/808
Renaming packages logback-includes and policy
[BROOKLYN-162]
Comment: https://issues.apache.org/jira/browse/BROOKLYN-162?focusedCommentId=14679851&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14679851
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/iyovcheva/incubator-brooklyn renaming_packages
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/808.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #808
----
commit 1aab788fac437303ff4caa8e91b608728e8098fb
Author: Ivana Yovcheva <iv...@gmail.com>
Date: 2015-08-10T11:48:20Z
[BROOKLYN-162] Renaming of logback-includes
commit 571fa3a337498e32f4cee90eeaa2be5b30d24c2a
Author: Ivana Yovcheva <iv...@gmail.com>
Date: 2015-08-10T12:08:15Z
[BROOKLYN-162] Renaming policy package
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Renaming packages logback-include...
Posted by bostko <gi...@git.apache.org>.
Github user bostko commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/808#issuecomment-129994305
@iyovcheva please check the osgi settings in usage/camp/src/test/resources/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Renaming package policy
Posted by iyovcheva <gi...@git.apache.org>.
Github user iyovcheva closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/808
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Renaming packages logback-include...
Posted by iyovcheva <gi...@git.apache.org>.
Github user iyovcheva closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/808
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Renaming packages logback-include...
Posted by iyovcheva <gi...@git.apache.org>.
GitHub user iyovcheva reopened a pull request:
https://github.com/apache/incubator-brooklyn/pull/808
Renaming packages logback-includes and policy
[BROOKLYN-162]
Comment: https://issues.apache.org/jira/browse/BROOKLYN-162?focusedCommentId=14679851&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14679851
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/iyovcheva/incubator-brooklyn renaming_packages
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/808.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #808
----
commit 5ef0b61fcbe39663e07039c76bbe36db603b4832
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2015-08-17T10:06:48Z
update zabbix for refactored brooklyn
commit 1f8d9324f4a0a8fe74a07e6a0095522b1ca5b299
Author: Ivana Yovcheva <iv...@gmail.com>
Date: 2015-08-17T11:49:58Z
[BROOKLYN-162] Renaming package policy
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Renaming packages logback-include...
Posted by iyovcheva <gi...@git.apache.org>.
Github user iyovcheva closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/808
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Renaming package policy
Posted by iyovcheva <gi...@git.apache.org>.
GitHub user iyovcheva reopened a pull request:
https://github.com/apache/incubator-brooklyn/pull/808
Renaming package policy
[BROOKLYN-162]
Comment: https://issues.apache.org/jira/browse/BROOKLYN-162?focusedCommentId=14679851&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14679851
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/iyovcheva/incubator-brooklyn renaming_packages
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/808.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #808
----
commit 5ef0b61fcbe39663e07039c76bbe36db603b4832
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2015-08-17T10:06:48Z
update zabbix for refactored brooklyn
commit 1f8d9324f4a0a8fe74a07e6a0095522b1ca5b299
Author: Ivana Yovcheva <iv...@gmail.com>
Date: 2015-08-17T11:49:58Z
[BROOKLYN-162] Renaming package policy
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Renaming packages logback-include...
Posted by iyovcheva <gi...@git.apache.org>.
GitHub user iyovcheva reopened a pull request:
https://github.com/apache/incubator-brooklyn/pull/808
Renaming packages logback-includes and policy
[BROOKLYN-162]
Comment: https://issues.apache.org/jira/browse/BROOKLYN-162?focusedCommentId=14679851&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14679851
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/iyovcheva/incubator-brooklyn renaming_packages
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/808.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #808
----
commit 357b004f4bc40fe90eab0258db0c47484fa695c1
Author: Ivana Yovcheva <iv...@gmail.com>
Date: 2015-08-11T09:04:26Z
[BROOKLYN-162] Renamed package policy
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Renaming packages logback-include...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/808#issuecomment-131735879
Thanks @iyovcheva - I'd be happy to merge except this PR now has conflicts with other recent changes in master. Can you rebase against master and let us know when that is done and asfbot has successfully run the tests again?
For future PRs, I'd recommend only renaming the packages in a single module in the commit. For example, you have focused on renaming those in the policy which is great. This PR also renamed things like `core/src/main/java/org/apache/brooklyn/policy/basic/AbstractEntityAdjunct.java`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Renaming package policy
Posted by iyovcheva <gi...@git.apache.org>.
GitHub user iyovcheva reopened a pull request:
https://github.com/apache/incubator-brooklyn/pull/808
Renaming package policy
[BROOKLYN-162]
Comment: https://issues.apache.org/jira/browse/BROOKLYN-162?focusedCommentId=14679851&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14679851
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/iyovcheva/incubator-brooklyn renaming_packages
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/808.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #808
----
commit 5ef0b61fcbe39663e07039c76bbe36db603b4832
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2015-08-17T10:06:48Z
update zabbix for refactored brooklyn
commit 1f8d9324f4a0a8fe74a07e6a0095522b1ca5b299
Author: Ivana Yovcheva <iv...@gmail.com>
Date: 2015-08-17T11:49:58Z
[BROOKLYN-162] Renaming package policy
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Renaming package policy
Posted by iyovcheva <gi...@git.apache.org>.
Github user iyovcheva closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/808
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Renaming packages logback-include...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/808#issuecomment-129852015
@iyovcheva thanks! The following tests fail however:
org.apache.brooklyn.camp.brooklyn.EnrichersYamlTest.testPropagatingEnricher
org.apache.brooklyn.camp.brooklyn.EnrichersYamlTest.testPropogateChildSensor
org.apache.brooklyn.camp.brooklyn.EnrichersSlightlySimplerYamlTest.testWithAppEnricher
From the errors, it looks related to the refactor. They all have the exception `ClassNotFoundException: Propagator`.
Could you take a look at that please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Renaming package policy
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/808
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---