You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Florian Barca <fb...@hortonworks.com> on 2015/01/30 20:41:47 UTC
Review Request 30458: Ambari Server Setup issues on Windows
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30458/
-----------------------------------------------------------
Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Jayush Luniya, Mahadev Konar, and Robert Levas.
Bugs: AMBARI-9390
https://issues.apache.org/jira/browse/AMBARI-9390
Repository: ambari
Description
-------
+Fixed erroneous exit when re-running setup after JDK/JCE were installed (Linux primarily, but Windows is affected too)
+Fixed SQL Server properties update when passing them via command-line arguments
Diffs
-----
ambari-common/src/main/python/ambari_commons/str_utils.py 9a9e954492e5b9080383f934094abe8a4fd95daa
ambari-server/src/main/python/ambari-server.py 3e46e71c751c32d40ee57036b84f1ff24dd6a7fe
ambari-server/src/main/python/ambari_server/dbConfiguration.py 819c5c3e1a1c29c9819329ceafb7c4ea2ddac3f9
ambari-server/src/main/python/ambari_server/dbConfiguration_windows.py 60308a0a6ba962ebfa1cefa3597b421ca88a8198
ambari-server/src/main/python/ambari_server/serverConfiguration.py 3f0484091dadfc12e2004089bd2957c9d8f32b38
ambari-server/src/main/python/ambari_server/serverSetup.py 8ba86470e5d4483a702b1192f14a48764d3471b9
ambari-server/src/test/python/TestAmbariServer.py caa1cf5067f37b69932a40d4726d5ddae7f964c7
Diff: https://reviews.apache.org/r/30458/diff/
Testing
-------
mvn clean test
ambari-server setup -j C:\jdk1.7.0_67
ambari-server setup -s
ambari-server setup -j C:\jdk1.7.0_67
ambari-server setup -s -j C:\jdk1.7.0_67 -a win01\SQLEXPRESS -n 1433 -d ambari0 -u hadoop -p BigWindows2012Data
Thanks,
Florian Barca
Re: Review Request 30458: Ambari Server Setup issues on Windows
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30458/#review70417
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Levas
On Jan. 30, 2015, 2:41 p.m., Florian Barca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30458/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2015, 2:41 p.m.)
>
>
> Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Jayush Luniya, Mahadev Konar, and Robert Levas.
>
>
> Bugs: AMBARI-9390
> https://issues.apache.org/jira/browse/AMBARI-9390
>
>
> Repository: ambari
>
>
> Description
> -------
>
> +Fixed erroneous exit when re-running setup after JDK/JCE were installed (Linux primarily, but Windows is affected too)
> +Fixed SQL Server properties update when passing them via command-line arguments
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/ambari_commons/str_utils.py 9a9e954492e5b9080383f934094abe8a4fd95daa
> ambari-server/src/main/python/ambari-server.py 3e46e71c751c32d40ee57036b84f1ff24dd6a7fe
> ambari-server/src/main/python/ambari_server/dbConfiguration.py 819c5c3e1a1c29c9819329ceafb7c4ea2ddac3f9
> ambari-server/src/main/python/ambari_server/dbConfiguration_windows.py 60308a0a6ba962ebfa1cefa3597b421ca88a8198
> ambari-server/src/main/python/ambari_server/serverConfiguration.py 3f0484091dadfc12e2004089bd2957c9d8f32b38
> ambari-server/src/main/python/ambari_server/serverSetup.py 8ba86470e5d4483a702b1192f14a48764d3471b9
> ambari-server/src/test/python/TestAmbariServer.py caa1cf5067f37b69932a40d4726d5ddae7f964c7
>
> Diff: https://reviews.apache.org/r/30458/diff/
>
>
> Testing
> -------
>
> mvn clean test
> ambari-server setup -j C:\jdk1.7.0_67
> ambari-server setup -s
> ambari-server setup -j C:\jdk1.7.0_67
>
> ambari-server setup -s -j C:\jdk1.7.0_67 -a win01\SQLEXPRESS -n 1433 -d ambari0 -u hadoop -p BigWindows2012Data
>
>
> Thanks,
>
> Florian Barca
>
>
Re: Review Request 30458: Ambari Server Setup issues on Windows
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30458/#review70416
-----------------------------------------------------------
Looks fine to me. You should have Emil Anca (@eanca) review this since he did the work related to JCE setup for [AMBARI-9228](https://issues.apache.org/jira/browse/AMBARI-9228).
- Robert Levas
On Jan. 30, 2015, 2:41 p.m., Florian Barca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30458/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2015, 2:41 p.m.)
>
>
> Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Jayush Luniya, Mahadev Konar, and Robert Levas.
>
>
> Bugs: AMBARI-9390
> https://issues.apache.org/jira/browse/AMBARI-9390
>
>
> Repository: ambari
>
>
> Description
> -------
>
> +Fixed erroneous exit when re-running setup after JDK/JCE were installed (Linux primarily, but Windows is affected too)
> +Fixed SQL Server properties update when passing them via command-line arguments
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/ambari_commons/str_utils.py 9a9e954492e5b9080383f934094abe8a4fd95daa
> ambari-server/src/main/python/ambari-server.py 3e46e71c751c32d40ee57036b84f1ff24dd6a7fe
> ambari-server/src/main/python/ambari_server/dbConfiguration.py 819c5c3e1a1c29c9819329ceafb7c4ea2ddac3f9
> ambari-server/src/main/python/ambari_server/dbConfiguration_windows.py 60308a0a6ba962ebfa1cefa3597b421ca88a8198
> ambari-server/src/main/python/ambari_server/serverConfiguration.py 3f0484091dadfc12e2004089bd2957c9d8f32b38
> ambari-server/src/main/python/ambari_server/serverSetup.py 8ba86470e5d4483a702b1192f14a48764d3471b9
> ambari-server/src/test/python/TestAmbariServer.py caa1cf5067f37b69932a40d4726d5ddae7f964c7
>
> Diff: https://reviews.apache.org/r/30458/diff/
>
>
> Testing
> -------
>
> mvn clean test
> ambari-server setup -j C:\jdk1.7.0_67
> ambari-server setup -s
> ambari-server setup -j C:\jdk1.7.0_67
>
> ambari-server setup -s -j C:\jdk1.7.0_67 -a win01\SQLEXPRESS -n 1433 -d ambari0 -u hadoop -p BigWindows2012Data
>
>
> Thanks,
>
> Florian Barca
>
>